Skip to content

Make it clear that we do not support the removed state #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Make it clear that we do not support the removed state #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/operator2/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ func (c *authOperator) Key() (metav1.Object, error) {
func (c *authOperator) Sync(obj metav1.Object) error {
operatorConfig := obj.(*operatorv1.Authentication)

// TODO bump and use IsOperatorManaged
if operatorConfig.Spec.ManagementState != operatorv1.Managed {
return nil // TODO do something better for all states
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/operator2/starter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,9 @@ func RunOperator(ctx *controllercmd.ControllerContext) error {

configOverridesController := unsupportedconfigoverridescontroller.NewUnsupportedConfigOverridesController(operatorClient, ctx.EventRecorder)
logLevelController := loglevel.NewClusterOperatorLoggingController(operatorClient, ctx.EventRecorder)
// TODO remove this controller once we support Unmanaged and Removed
// TODO remove this controller once we support Removed
managementStateController := management.NewOperatorManagementStateController(clusterOperatorName, operatorClient, ctx.EventRecorder)
management.SetOperatorNotRemovable()
// TODO move to config observers
// configobserver.NewConfigObserver(...)

Expand Down