Skip to content

cherry-picking #366: Bug 1732929: Modify machine-api-controller clusterrole for daemonsets #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

cherry-picking #366: Bug 1732929: Modify machine-api-controller clusterrole for daemonsets #393

merged 1 commit into from
Sep 4, 2019

Conversation

vikaschoudhary16
Copy link
Contributor

@vikaschoudhary16 vikaschoudhary16 commented Sep 3, 2019 •
edited
Loading

cherry-picking #366

This change is required to fix CI on the PR, openshift/cluster-api-provider-aws#253

daemonsets.apps "node-ca" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-operator" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-image-registry": node-ca-brnl4; daemonsets.apps "machine-config-daemon" is forbidden: User "system:serviceaccount:openshift-machine-api:machine-api-operator" cannot get resource "daemonsets" in API group "apps" in the namespace "openshift-machine-config-operator":

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-aws/253/pull-ci-openshift-cluster-api-provider-aws-release-4.1-e2e-aws-operator/63/artifacts/e2e-aws-operator/pods/openshift-machine-api_machine-api-controllers-794d86ff7-sz57x_machine-controller.log

Fixing:

https://bugzilla.redhat.com/show_bug.cgi?id=1713061 (Missing node prevents machine from being delete)
https://bugzilla.redhat.com/show_bug.cgi?id=1732929 (4.1.4 cluster creating 400+ eviction requests a second)
Pinning dependencies, cluster-api and cluster-api-actuator-pkg, to 4.1 release

@openshift-ci-robot
Copy link
Contributor

@vikaschoudhary16: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Cherry-Pick: Modify machine-api-controller clusterrole for daemonsets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2019
@enxebre enxebre added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 3, 2019
@enxebre
Copy link
Member

enxebre commented Sep 3, 2019

can you add more context, bugzilla references and link to related aws PR?
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019
@enxebre enxebre removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 3, 2019
@openshift-ci-robot
Copy link
Contributor

@vikaschoudhary16: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Cherry-Pick: Modify machine-api-controller clusterrole for daemonsets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikaschoudhary16 vikaschoudhary16 changed the title Cherry-Pick: Modify machine-api-controller clusterrole for daemonsets Bug 1732929: Modify machine-api-controller clusterrole for daemonsets Sep 3, 2019
@openshift-ci-robot
Copy link
Contributor

@vikaschoudhary16: This pull request references Bugzilla bug 1732929, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1732929: Modify machine-api-controller clusterrole for daemonsets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 3, 2019
@openshift-ci-robot
Copy link
Contributor

@vikaschoudhary16: This pull request references Bugzilla bug 1732929, which is valid.

In response to this:

Bug 1732929: Modify machine-api-controller clusterrole for daemonsets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor

frobware commented Sep 3, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2019
@vikaschoudhary16
Copy link
Contributor Author

/test integration

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre enxebre changed the title Bug 1732929: Modify machine-api-controller clusterrole for daemonsets cherry-picking #366: Bug 1732929: Modify machine-api-controller clusterrole for daemonsets Sep 3, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Member

enxebre commented Sep 3, 2019

cc @mfojtik

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Member

enxebre commented Sep 3, 2019

/retest

1 similar comment
@enxebre
Copy link
Member

enxebre commented Sep 3, 2019

/retest

@vikaschoudhary16
Copy link
Contributor Author

/test integration

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 3, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2019
@vikaschoudhary16 vikaschoudhary16 force-pushed the fix-rbac-4-drain branch 5 times, most recently from 660fcf8 to 7ee94b8 Compare September 4, 2019 03:53
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2019
@vikaschoudhary16
Copy link
Contributor Author

/retest

@vikaschoudhary16
Copy link
Contributor Author

/test integration

@ingvagabund
Copy link
Member

/refresh

@vikaschoudhary16
Copy link
Contributor Author

/retest

@vikaschoudhary16
Copy link
Contributor Author

/refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 4, 2019 •
edited
Loading

@vikaschoudhary16: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/jenkins/integration 7ee94b8 link /test integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vikaschoudhary16
Copy link
Contributor Author

/retest

@vikaschoudhary16
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 4, 2019
@vikaschoudhary16
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2019
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@ingvagabund ingvagabund added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit 545465b into openshift:release-4.1 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@enxebre enxebre

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vikaschoudhary16 @openshift-ci-robot @enxebre @frobware @openshift-bot @ingvagabund @openshift-merge-robot