Skip to content

reduce reconciling events #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2019
Merged

reduce reconciling events #422

merged 2 commits into from
Oct 22, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Oct 21, 2019 •
edited
Loading

MAO is going through reconciles about every three minutes consistently. This is because the mao deployment receives update events which I can only think are coming from the CVO.
e.g

When CVO calls ensureDeployment it might wrongly return modified=true and do an api server update extra call when comparing the raw spec (without defaulted values) against the version fetch from the API server. See also openshift/cluster-version-operator#256
This is one of a series of PRs to simplify mao reconciling loop and avoid unnecessary reconciling loops.
Follow up:

  • Stop mao logic from watching mao/cao deployment and only watch "owned" deployments

@enxebre
Copy link
Member Author

enxebre commented Oct 21, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2019
@enxebre enxebre force-pushed the resync-events branch 3 times, most recently from 1efd2e0 to 5365d7a Compare October 22, 2019 07:19
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2019
@enxebre enxebre changed the title Add resource events logs reduce reconciling events Oct 22, 2019
@enxebre
Copy link
Member Author

enxebre commented Oct 22, 2019

cc @wking

@enxebre
Copy link
Member Author

enxebre commented Oct 22, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@enxebre
Copy link
Member Author

enxebre commented Oct 22, 2019

/test e2e-azure-operator

@enxebre
Run only one worker for mao queue
03f0998 
The mao queue has minimum load. Using only one worker simplifies and ease debugging and logging
@enxebre
Add defaulted values to mao deployment
9eee17e 
When CVO calls ensureDeployment it might wrongly return modified=true and do an api server update extra call when comparing the raw spec against the version fetch from the API server
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 22, 2019 •
edited
Loading

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-azure-operator 9eee17e link /test e2e-azure-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bison
bison approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@openshift-merge-robot openshift-merge-robot merged commit c5c0be5 into openshift:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison bison approved these changes

@frobware frobware Awaiting requested review from frobware

Assignees

@bison bison

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enxebre @openshift-ci-robot @bison @openshift-merge-robot