Update the CI registry in the registry Dockerfile and copy OLM_VERSION to root directory #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick workaround to the root OLM Dockerfile needing this file present.
Migrate to using container images from the registry.ci.* registry now that most images have been moved to that registry.
openshift-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ankitathomas
pushed a commit
to ankitathomas/operator-framework-olm
that referenced
this pull request
Apr 6, 2021
fix(health): move health to its own package with the right package name (upstream operator-registry commit: 8cbd766324a031257811216bd4929b651a754cfc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator-registry Dockerfile currently references images that are now migrated to the registry.ci.openshift.org registry instead of registry.svc.ci.openshift.org which is failing image tests when attempting to grab that particular Go manifest tag.
Copy the OLM_VERSION from the OLM staging repository to the root repository as the OLM Dockerifle is expecting that file is present. There are a couple of different ways we can handle this, including updating the path to this file, but this kind of changes is a workaround anyways to get a base set of prow tests working so I don't think how we get access to this file is all that important at the moment.