feat(sub): Include IP failure condition message in sub status condition #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Currently when an InstallPlan fails, due to bundle unpacking error
is pending due to errors like invalid operatorgroup, or pending bundle unpacking job
the reason is propagated to the Subscription that owns it. The message for the failure is
however missing from the Subscription condition.
eg
```
kind: Subscription
status:
conditions:
- lastTransitionTime: "2021-07-07T17:55:20Z"
reason: Installing
status: "True"
type: InstallPlanPending
```
This PR propagates the message assosiated with the reason in the InstallPlan
condition when an InstallPlan is either pending, or has failed permanantly.
eg
```
kind: Subscription
status:
conditions:
- lastTransitionTime: "2021-07-07T17:55:20Z"
message: no operator group found that is managing this namespace
reason: Installing
status: "True"
type: InstallPlanPending
```
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 303608dbe3c9cbfe4679bafc43a6acafea9f7e9e
Signed-off-by: Anik Bhattacharjee <[email protected]>
|
@anik120: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
kevinrizza
pushed a commit
to kevinrizza/operator-framework-olm
that referenced
this pull request
Jul 21, 2021
Signed-off-by: Vu Dinh <[email protected]> Upstream-repository: api Upstream-commit: 0dcbd99f9e5fea8a2ffbad6088437809a07d6d27
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/operator-framework-olm
that referenced
this pull request
Aug 4, 2021
Upstream-commit: 0dcbd99f9e5fea8a2ffbad6088437809a07d6d27 Upstream-repository: api Signed-off-by: Vu Dinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when an InstallPlan fails, due to bundle unpacking error
is pending due to errors like invalid operatorgroup, or pending bundle unpacking job
the reason is propagated to the Subscription that owns it. The message for the failure is
however missing from the Subscription condition.
eg
This PR propagates the message assosiated with the reason in the InstallPlan
condition when an InstallPlan is either pending, or has failed permanantly.
eg
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 303608dbe3c9cbfe4679bafc43a6acafea9f7e9e
Signed-off-by: Anik Bhattacharjee [email protected]