Bug 1986023: Translate legacy "bundle dependencies" to properties. #134
Conversation
Operator dependencies are expressed as properties, but there was initially a notion of dependencies as distinct from properties. For that reason, catalog-operator must support existing catalog images that serve separate Bundle.dependencies and Bundle.properties fields by translating the three legacy dependency types (olm.label, olm.package, and olm.gvk) into their corresponding properties. Signed-off-by: Ben Luddy <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: c918a85eb7ef0c1ea58ebf27fabd8d2393afe9b3
openshift-ci
bot
added
the
bugzilla/severity-high
|
@benluddy: This pull request references Bugzilla bug 1986023, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
|
@benluddy: This pull request references Bugzilla bug 1986023, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Looks like a console CatalogSource test spec that checks the value of a Status element timed out, twice. I can't find any OLM resources from the time of failure, so if someone picks up triaging this, I suggest checking:
/test e2e-aws-console-olm (doesn't hurt to check for a flake while digging into this) |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@njhale: This pull request references Bugzilla bug 1986023, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
[patch-manager] 🚀 Approved for z-stream by score: 1.00 picked |
ecordell
added
the
cherry-pick-approved
|
/retest |
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1986023 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[patch-manager] 🚀 Approved for z-stream by score: 1.00 picked |
* Add validation to CSV name length Given CSV's name is used as label for OLM, its length should be validated to ensure it's not over the label character limit which is currently set at 63 character. This commit will enable CSV validation returning an error if CSV's name is more than 63 characters. Signed-off-by: Vu Dinh <[email protected]> * Add unit test for CSV with bad name The unit test is targeted with CSV with name that is over 63 characters limit. Signed-off-by: Vu Dinh <[email protected]> Upstream-repository: api Upstream-commit: db8dead7a7c5091f2ce48fef369af973ee2a4f13
Operator dependencies are expressed as properties, but there was
initially a notion of dependencies as distinct from properties. For
that reason, catalog-operator must support existing catalog images
that serve separate Bundle.dependencies and Bundle.properties fields
by translating the three legacy dependency types (olm.label,
olm.package, and olm.gvk) into their corresponding properties.