Bug 1978340: Ensure the PackageServer CSV contains a hard pod anti-affinity configuration #137

timflannagan · 2021-07-27T22:13:47Z

Ensure the PackageServer CSV resource follows the recommended normal/HA
OCP cluster pod anti affinity configuration so multiple replicas get
placed on different nodes.

For more information on HA/non-HA expectations:

https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#high-availability

Update the scripts/packageserver-deployment.patch.yaml to ensure that
the default (e.g. HA) PackageServer CSV resource matches those outlined
conventions.

openshift-ci · 2021-07-27T22:13:51Z

@timflannagan: This pull request references Bugzilla bug 1978340, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1978340: Ensure the PackageServer CSV contains a hard pod anti-affinity configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-07-27T22:14:13Z

Need to update to include a poddisruptionbudget resource for the packageserver deployment and add some tests.

/hold

timflannagan · 2021-07-27T22:14:42Z

/bugzilla refresh

openshift-ci · 2021-07-27T22:14:48Z

@timflannagan: This pull request references Bugzilla bug 1978340, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…t with the rest of the YAML manifests

timflannagan · 2021-08-26T15:57:29Z

/hold cancel

timflannagan · 2021-08-26T15:58:03Z

PDB manifest looks off.

/hold

…eServer component

…finity configuration Ensure the PackageServer CSV resource follows the recommended normal/HA OCP cluster pod anti affinity configuration so multiple replicas get placed on different nodes. For more information on HA/non-HA expectations: - https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#high-availability Update the scripts/packageserver-deployment.patch.yaml to ensure that the default (e.g. HA) PackageServer CSV resource matches those outlined conventions.

timflannagan · 2021-08-26T17:45:34Z

/hold cancel

dinhxuanvu

/lgtm

dinhxuanvu · 2021-08-26T19:35:44Z

/hold for another review.

openshift-ci · 2021-08-26T19:42:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dinhxuanvu,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

timflannagan · 2021-08-26T19:43:29Z

/retest

timflannagan · 2021-08-29T21:37:13Z

/retest

timflannagan · 2021-08-30T01:59:43Z

/retest

timflannagan · 2021-08-30T14:37:51Z

/hold cancel

openshift-ci · 2021-08-30T14:38:38Z

@timflannagan: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#137

Bugzilla bug 1978340 has been moved to the MODIFIED state.

In response to this:

Bug 1978340: Ensure the PackageServer CSV contains a hard pod anti-affinity configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* add timestamp field Signed-off-by: Ish Shah <[email protected]> * Add timestamp to scorecard test result Signed-off-by: Ish Shah <[email protected]> * Change type and struct Signed-off-by: Ish Shah <[email protected]> * Update pkg/apis/scorecard/v1alpha3/test_types.go Co-authored-by: Joe Lanford <[email protected]> * make manifests/generate; Signed-off-by: Ish Shah <[email protected]> * Update pkg/apis/scorecard/v1alpha3/test_types.go Co-authored-by: Joe Lanford <[email protected]> Co-authored-by: Joe Lanford <[email protected]> Upstream-repository: api Upstream-commit: 7d591fff8bd551160e51dedef17debbe52145019

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 27, 2021

openshift-ci bot requested review from anik120 and benluddy July 27, 2021 22:13

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 27, 2021

openshift-ci bot requested a review from jianzhangbjz July 27, 2021 22:14

manifests,scripts: Update the PSM deployment filename to be consisten…

7a6282c

…t with the rest of the YAML manifests

timflannagan force-pushed the packageserver-ha-expectations branch from 775c2e1 to 8709c9b Compare August 26, 2021 15:24

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021

manifests,scripts: Add a PodDisruptionBudget resources for the Packag…

f4e6729

…eServer component

timflannagan force-pushed the packageserver-ha-expectations branch from 8709c9b to d53e500 Compare August 26, 2021 16:02

timflannagan force-pushed the packageserver-ha-expectations branch from d53e500 to 9647632 Compare August 26, 2021 16:13

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021

dinhxuanvu approved these changes Aug 26, 2021

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2021

openshift-ci bot assigned dinhxuanvu Aug 26, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2021

openshift-merge-robot merged commit ca5d761 into openshift:master Aug 30, 2021

timflannagan deleted the packageserver-ha-expectations branch August 30, 2021 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bug 1978340: Ensure the PackageServer CSV contains a hard pod anti-affinity configuration #137

Bug 1978340: Ensure the PackageServer CSV contains a hard pod anti-affinity configuration #137

Uh oh!

timflannagan commented Jul 27, 2021

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

timflannagan commented Jul 27, 2021

Uh oh!

timflannagan commented Jul 27, 2021

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

dinhxuanvu left a comment

Uh oh!

dinhxuanvu commented Aug 26, 2021

Uh oh!

openshift-ci bot commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 29, 2021

Uh oh!

timflannagan commented Aug 30, 2021

Uh oh!

timflannagan commented Aug 30, 2021

Uh oh!

openshift-ci bot commented Aug 30, 2021

Uh oh!

Uh oh!

Bug 1978340: Ensure the PackageServer CSV contains a hard pod anti-affinity configuration #137

Bug 1978340: Ensure the PackageServer CSV contains a hard pod anti-affinity configuration #137

Uh oh!

Conversation

timflannagan commented Jul 27, 2021

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

timflannagan commented Jul 27, 2021

Uh oh!

timflannagan commented Jul 27, 2021

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

dinhxuanvu left a comment

Choose a reason for hiding this comment

Uh oh!

dinhxuanvu commented Aug 26, 2021

Uh oh!

openshift-ci bot commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 26, 2021

Uh oh!

timflannagan commented Aug 29, 2021

Uh oh!

timflannagan commented Aug 30, 2021

Uh oh!

timflannagan commented Aug 30, 2021

Uh oh!

openshift-ci bot commented Aug 30, 2021

Uh oh!

Uh oh!