Bug 1943284: Fix nil function in buildContext return values #150

timflannagan · 2021-08-03T19:37:38Z

fix nil function in buildcontext

Signed-off-by: Jose R. Gonzalez [email protected]

add TestBuildContext in indexer

Signed-off-by: Jose R. Gonzalez [email protected]

Upstream-repository: operator-registry
Upstream-commit: 673849b334b03fb7776cd9e741403cfe5bf16cfd

* fix nil function in buildcontext Signed-off-by: Jose R. Gonzalez <[email protected]> * add TestBuildContext in indexer Signed-off-by: Jose R. Gonzalez <[email protected]> Upstream-repository: operator-registry Upstream-commit: 673849b334b03fb7776cd9e741403cfe5bf16cfd

timflannagan · 2021-08-03T19:38:16Z

/bugzilla-refresh

openshift-ci · 2021-08-03T19:38:43Z

@timflannagan: This pull request references Bugzilla bug 1926522, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1926522: Fix nil function in buildContext return values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-08-03T19:39:26Z

/bugzilla refresh

openshift-ci · 2021-08-03T19:39:29Z

@timflannagan: This pull request references Bugzilla bug 1926522, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-03T19:40:01Z

@timflannagan: This pull request references Bugzilla bug 1943284, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1943284: Fix nil function in buildContext return values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-08-04T17:31:33Z

/retest

timflannagan · 2021-08-05T16:03:49Z

/retest

ankitathomas · 2021-08-12T14:23:10Z

/test e2e-upgrade

timflannagan · 2021-08-12T21:55:58Z

/retest

openshift-ci · 2021-08-12T21:56:07Z

@timflannagan: An error was encountered adding this pull request to the external tracker bugs for bug 1943284 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


JSONRPC error 32000: Red Hat Bugzilla's database reported a query serialization error. Most likely this occurred because another user or process attempted to change the same data that you were attempting to change. Please press Back and retry the transaction.  UPDATE bugs SET delta_ts = ? WHERE bug_id = ? at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1516.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1943284: Fix nil function in buildContext return values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-08-12T21:56:08Z

whoops 😆

openshift-ci · 2021-08-12T21:56:09Z

@timflannagan: This pull request references Bugzilla bug 1943284. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1943284: Fix nil function in buildContext return values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-08-12T21:56:27Z

/bugzilla refresh

openshift-ci · 2021-08-12T21:56:34Z

@timflannagan: This pull request references Bugzilla bug 1943284, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2021-08-16T15:29:22Z

/retest

timflannagan · 2021-08-19T19:00:01Z

/retest

njhale

/lgtm

openshift-ci · 2021-08-20T18:07:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njhale,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

njhale · 2021-08-20T18:08:10Z

staging/operator-registry/pkg/lib/indexer/indexer.go

@@ -396,6 +396,9 @@ func copyDatabaseTo(databaseFile, targetDir string) (string, error) {
 }

 func buildContext(generate bool, requestedDockerfile string) (buildDir, outDockerfile string, cleanup func(), err error) {
+	// set cleanup to a no-op until explicitly set
+	cleanup = func() {}


clients should probably be checking return values for nil before using them.

njhale · 2021-08-20T18:08:58Z

staging/operator-registry/pkg/lib/indexer/indexer_test.go

@@ -83,3 +83,61 @@ func TestGeneratePackageYaml(t *testing.T) {

 	_ = os.RemoveAll("./package.yaml")
 }
+
+func TestBuildContext(t *testing.T) {
+	// TODO(): Test does not currently have a clean way


those functions could be improved by using the new fs.FS abstractions -- then it would be easier to test

openshift-bot · 2021-08-20T21:36:16Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-20T23:55:23Z

@timflannagan: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#150

Bugzilla bug 1943284 has been moved to the MODIFIED state.

In response to this:

Bug 1943284: Fix nil function in buildContext return values

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 3, 2021

openshift-ci bot requested review from awgreene and kevinrizza August 3, 2021 19:38

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021

timflannagan changed the title ~~Bug 1926522: Fix nil function in buildContext return values~~ Bug 1943284: Fix nil function in buildContext return values Aug 3, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 3, 2021

openshift-ci bot requested a review from jianzhangbjz August 3, 2021 19:40

timflannagan closed this Aug 12, 2021

timflannagan reopened this Aug 12, 2021

njhale approved these changes Aug 20, 2021

View reviewed changes

openshift-ci bot assigned njhale Aug 20, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021

njhale reviewed Aug 20, 2021

View reviewed changes

openshift-merge-robot merged commit 0934d42 into openshift:master Aug 20, 2021

Bug 1943284: Fix nil function in buildContext return values #150

Bug 1943284: Fix nil function in buildContext return values #150

Uh oh!

Conversation

timflannagan commented Aug 3, 2021

Uh oh!

timflannagan commented Aug 3, 2021

Uh oh!

openshift-ci bot commented Aug 3, 2021

Uh oh!

timflannagan commented Aug 3, 2021

Uh oh!

openshift-ci bot commented Aug 3, 2021

Uh oh!

openshift-ci bot commented Aug 3, 2021

Uh oh!

timflannagan commented Aug 4, 2021

Uh oh!

timflannagan commented Aug 5, 2021

Uh oh!

ankitathomas commented Aug 12, 2021

Uh oh!

timflannagan commented Aug 12, 2021

Uh oh!

openshift-ci bot commented Aug 12, 2021

Uh oh!

timflannagan commented Aug 12, 2021

Uh oh!

openshift-ci bot commented Aug 12, 2021

Uh oh!

timflannagan commented Aug 12, 2021

Uh oh!

openshift-ci bot commented Aug 12, 2021

Uh oh!

timflannagan commented Aug 16, 2021

Uh oh!

timflannagan commented Aug 19, 2021

Uh oh!

njhale left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Aug 20, 2021

Uh oh!

njhale Aug 20, 2021

Choose a reason for hiding this comment

Uh oh!

njhale Aug 20, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Aug 20, 2021

Uh oh!

openshift-ci bot commented Aug 20, 2021

Uh oh!

Uh oh!