-
Notifications
You must be signed in to change notification settings - Fork 71
Bug 1989723: Improve ensure methods #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Problem: When calling a registry's ensure methods, if the resource is deleted between the get and delete calls the ensure method fails due to a 404 error. Solution: When deleting an object, ignore 404 errors. Signed-off-by: Alexander Greene <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 1b5afdceabb7a130f3f3d923b9784c007f9f4f2e
@awgreene: This pull request references Bugzilla bug 1989723, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It looks like you need to run |
You need to run |
Committed the vendor changes @dinhxuanvu and @timflannagan |
/retest |
@awgreene: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/bugzilla-refresh |
The team has decided that this bug is not sever enough to warrant backporting, closing this PR. |
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
* Add validation for Kind and APIVersion Signed-off-by: Josef Karasek <[email protected]> * Update pkg/validation/internal/csv.go Co-authored-by: Eric Stroczynski <[email protected]> Co-authored-by: Eric Stroczynski <[email protected]> Upstream-repository: api Upstream-commit: c9b1e7ef82b8081a3eb52c48d0ca9039f2e3a27e
Problem: When calling a registry's ensure methods, if the resource is
deleted between the get and delete calls the ensure method fails due
to a 404 error.
Solution: When deleting an object, ignore 404 errors.
Signed-off-by: Alexander Greene [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1b5afdceabb7a130f3f3d923b9784c007f9f4f2e