Skip to content

Bug 1989704: fix(openshift): block upgrades on invalid max properties (#2302) #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2021
Merged

Bug 1989704: fix(openshift): block upgrades on invalid max properties (#2302) #154

merged 1 commit into from
Aug 5, 2021

Conversation

njhale
Copy link
Contributor

@njhale njhale commented Aug 4, 2021

Block OpenShift upgrades while:

  • olm.maxOpenShiftVersion properties have invalid values
  • cluster information is unavailable; e.g. the desired version of the cluster is undefined
  • an installed operator has declared more than one olm.MaxOpenShiftVersion
    property

See https://bugzilla.redhat.com/show_bug.cgi?id=1986753 for motivation.

Signed-off-by: Nick Hale [email protected]

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 734c6d031cbb2eb00acdf6cac91bba3d33311a0d

@njhale
fix(openshift): block upgrades on invalid max properties (#2302)
9014047 
Block OpenShift upgrades while:

- olm.maxOpenShiftVersion properties have invalid values
- cluster information is unavailable; e.g. the desired version of the cluster is undefined
- an installed operator has declared more than one olm.MaxOpenShiftVersion
  property

See https://bugzilla.redhat.com/show_bug.cgi?id=1986753 for motivation.

Signed-off-by: Nick Hale <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 734c6d031cbb2eb00acdf6cac91bba3d33311a0d
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@njhale: This pull request references Bugzilla bug 1989704, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1989704: fix(openshift): block upgrades on invalid max properties (#2302)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot merged commit e47245b into openshift:master Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@njhale: All pull requests linked via external trackers have merged:

Bugzilla bug 1989704 has been moved to the MODIFIED state.

In response to this:

Bug 1989704: fix(openshift): block upgrades on invalid max properties (#2302)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Sep 8, 2021
@laxmikantbpandhare @ankitathomas
modified the controller-runtime and controller-tools versions (opensh…
ca272bf 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Sep 9, 2021
@laxmikantbpandhare @ankitathomas
modified the controller-runtime and controller-tools versions (opensh…
9ce4dcf 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
ankitathomas pushed a commit to ankitathomas/operator-framework-olm that referenced this pull request Sep 14, 2021
@laxmikantbpandhare @ankitathomas
modified the controller-runtime and controller-tools versions (opensh…
6074bdf 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 28, 2021
@laxmikantbpandhare @timflannagan
modified the controller-runtime and controller-tools versions (opensh…
597bb14 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 28, 2021
@laxmikantbpandhare @timflannagan
modified the controller-runtime and controller-tools versions (opensh…
912b11f 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 29, 2021
@laxmikantbpandhare @timflannagan
modified the controller-runtime and controller-tools versions (opensh…
a14fc5e 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Sep 29, 2021
@laxmikantbpandhare @timflannagan
modified the controller-runtime and controller-tools versions (opensh…
572257d 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Oct 13, 2021
@laxmikantbpandhare @timflannagan
modified the controller-runtime and controller-tools versions (opensh…
c7baf7b 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
njhale pushed a commit to njhale/operator-framework-olm that referenced this pull request Oct 18, 2021
@laxmikantbpandhare @njhale
modified the controller-runtime and controller-tools versions (opensh…
c62dff9 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
njhale pushed a commit to njhale/operator-framework-olm that referenced this pull request Oct 18, 2021
@laxmikantbpandhare @njhale
modified the controller-runtime and controller-tools versions (opensh…
dcbe770 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
timflannagan pushed a commit to njhale/operator-framework-olm that referenced this pull request Nov 15, 2021
@laxmikantbpandhare @timflannagan
modified the controller-runtime and controller-tools versions (opensh…
c509642 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@laxmikantbpandhare @perdasilva
modified the controller-runtime and controller-tools versions (opensh…
f72950f 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@laxmikantbpandhare @perdasilva
modified the controller-runtime and controller-tools versions (opensh…
c1d044a 
…ift#154)

* modified the controller-runtime and controller-tools versions

* ran vendor command and added files

* ran make manifests

Upstream-repository: api
Upstream-commit: a80624eab36b2005fa5d84c9b539bb4817e44daa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@awgreene awgreene Awaiting requested review from awgreene

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njhale @timflannagan @openshift-bot