Bug 1990850: Handle property and dependency values of type BLOB in ListBundles. #159

benluddy · 2021-08-06T12:40:18Z

Per https://www.sqlite.org/datatype3.html#type_affinity:

In order to maximize compatibility between SQLite and other database
engines, and so that the example above will work on SQLite as it
does on other SQL database engines, SQLite supports the concept of
"type affinity" on columns. The type affinity of a column is the
recommended type for data stored in that column. The important idea
here is that the type is recommended, not required. Any column can
still store any type of data. It is just that some columns, given
the choice, will prefer to use one storage class over another. The
preferred storage class for a column is called its "affinity".

Even though the properties and dependencies tables are created with
column affinity TEXT on both their "type" and "value" columns, SQLite
does not require values stored in those columns to have that type.

The query backing the registry.ListBundles API recently began using
the json_object function from the json1 SQLite
extension (https://www.sqlite.org/json1.html#jobj), which does not
support arguments of type BLOB. The docs state:

If any argument to json_object() is a BLOB then an error is thrown.

But it seems that no error is actually being returned. Instead, the
result set it empty. This may be an issue with the SQLite driver? It
seems to produce an error in sqlite3's interactive mode.

Per https://www.sqlite.org/datatype3.html#type_affinity: > In order to maximize compatibility between SQLite and other database > engines, and so that the example above will work on SQLite as it > does on other SQL database engines, SQLite supports the concept of > "type affinity" on columns. The type affinity of a column is the > recommended type for data stored in that column. The important idea > here is that the type is recommended, not required. Any column can > still store any type of data. It is just that some columns, given > the choice, will prefer to use one storage class over another. The > preferred storage class for a column is called its "affinity". Even though the properties and dependencies tables are created with column affinity TEXT on both their "type" and "value" columns, SQLite does not require values stored in those columns to have that type. The query backing the registry.ListBundles API recently began using the json_object function from the json1 SQLite extension (https://www.sqlite.org/json1.html#jobj), which does not support arguments of type BLOB. The docs state: > If any argument to json_object() is a BLOB then an error is thrown. But it seems that no error is actually being returned. Instead, the result set it empty. This may be an issue with the SQLite driver? It seems to produce an error in sqlite3's interactive mode. Signed-off-by: Ben Luddy <[email protected]> Upstream-repository: operator-registry Upstream-commit: c2fc1fd45d64401b512969f83011868940d83a59

openshift-ci · 2021-08-06T12:40:24Z

@benluddy: This pull request references Bugzilla bug 1990850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1990850: Handle property and dependency values of type BLOB in ListBundles.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-08-06T12:40:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benluddy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kevinrizza · 2021-08-06T12:48:45Z

/lgtm

openshift-bot · 2021-08-06T14:52:17Z

/retest-required