Skip to content

Bug 1989460: chore(opm): note that whole dependency packages are added to the diff for now #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2021
Merged

Bug 1989460: chore(opm): note that whole dependency packages are added to the diff for now #161

merged 1 commit into from
Aug 13, 2021

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Aug 11, 2021

chore(opm): note that whole dependency packages are added to the diff for now (#740)

Signed-off-by: Eric Stroczynski [email protected]

Upstream-repository: operator-registry
Upstream-commit: 4ea7a6b6da0d4b6fa2a8a73568bf0ed10a1cfed5

@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: This pull request references Bugzilla bug 1989796, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1989796: chore(opm): note that whole dependency packages are added to the diff for now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from exdx and kevinrizza August 11, 2021 19:34
@estroz estroz changed the title Bug 1989796: chore(opm): note that whole dependency packages are added to the diff for now Bug 1989460: chore(opm): note that whole dependency packages are added to the diff for now Aug 11, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: This pull request references Bugzilla bug 1989460, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: This pull request references Bugzilla bug 1989460, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1989460: chore(opm): note that whole dependency packages are added to the diff for now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Aug 11, 2021
@estroz
chore(opm): note that whole dependency packages are added to the diff…
b3c146f 
… for now (#740)

Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: operator-registry
Upstream-commit: 4ea7a6b6da0d4b6fa2a8a73568bf0ed10a1cfed5
@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: This pull request references Bugzilla bug 1989460, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 11, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1989460 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: This pull request references Bugzilla bug 1989460, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
@njhale
Copy link
Contributor

njhale commented Aug 12, 2021

/retest

@njhale
Copy link
Contributor

njhale commented Aug 12, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
ankitathomas
ankitathomas approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, estroz, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ankitathomas,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 12, 2021

/test e2e-upgrade

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 859431b into openshift:master Aug 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2021

@estroz: All pull requests linked via external trackers have merged:

Bugzilla bug 1989460 has been moved to the MODIFIED state.

In response to this:

Bug 1989460: chore(opm): note that whole dependency packages are added to the diff for now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz estroz deleted the bz/1989460 branch August 13, 2021 06:41
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
@timflannagan
fix(validators): check object GVK in bundle service account validator (…
a5f3a60 
…openshift#161)

Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: cdabf11822cbff3914e444ab6e30b8145a0a9b6a
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
@timflannagan
fix(validators): check object GVK in bundle service account validator (…
509e672 
…openshift#161)

Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: cdabf11822cbff3914e444ab6e30b8145a0a9b6a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
fix(validators): check object GVK in bundle service account validator (…
9c92c9d 
…openshift#161)

Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: cdabf11822cbff3914e444ab6e30b8145a0a9b6a
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
fix(validators): check object GVK in bundle service account validator (…
7082274 
…openshift#161)

Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: cdabf11822cbff3914e444ab6e30b8145a0a9b6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas ankitathomas approved these changes

@exdx exdx Awaiting requested review from exdx

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@ankitathomas ankitathomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estroz @njhale @openshift-bot @ankitathomas