Skip to content

Bug 1982781: fix(deprecate): explicit pkg rm drops latest deprecated #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Bug 1982781: fix(deprecate): explicit pkg rm drops latest deprecated #162

merged 1 commit into from
Aug 12, 2021

Conversation

njhale
Copy link
Contributor

@njhale njhale commented Aug 11, 2021

  • When using opm index|registry rm , drop the "latest" related bundles
    from the deprecated table. This makes "un-deprecating" a bundle
    possible, which is useful if that bundle was deprecated by
    accident
  • Add a migration and logic on deprecatetruncate that drops
    truncated bundles (i.e. w/o assoc. channel_entry rows) from the deprecated
    table, clearing the "deprecation history" so that operations post package
    removal don't assume a truncated bundle should be deprecated

See https://bugzilla.redhat.com/show_bug.cgi?id=1982781 for motivation

Signed-off-by: Nick Hale [email protected]
Upstream-repository: operator-registry
Upstream-commit: 29e90dea6a1c2ef12075ca866284cd8f267c2bba

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@njhale: This pull request references Bugzilla bug 1982781, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1982781: fix(deprecate): explicit pkg rm drops latest deprecated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
fix(deprecate): explicit pkg rm drops latest deprecated
c41b523 
- When using opm index|registry rm <pkg>, drop the "latest" related bundles
from the deprecated table. This makes "un-deprecating" a bundle
possible, which is useful if that  bundle was deprecated by
accident
- Add a migration and logic on deprecatetruncate that drops
truncated bundles (i.e. w/o assoc. channel_entry rows) from the deprecated
table, clearing the "deprecation history" so that operations post package
removal don't assume a truncated bundle should be deprecated

See https://bugzilla.redhat.com/show_bug.cgi?id=1982781 for motivation

Signed-off-by: Nick Hale <[email protected]>
Upstream-repository: operator-registry
Upstream-commit: 29e90dea6a1c2ef12075ca866284cd8f267c2bba
@njhale njhale force-pushed the fix/rmpkg-deprecate branch from 1a2a06b to c41b523 Compare August 11, 2021 19:32
@njhale
Copy link
Contributor Author

njhale commented Aug 11, 2021

/bugzilla refresh

@ankitathomas
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@njhale: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1982781 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from anik120 and hasbro17 August 11, 2021 19:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@exdx
Copy link
Contributor

exdx commented Aug 11, 2021

/approve
Is this a backwards-incompatible change? I guess we can just call it a bug.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@openshift-bot: This pull request references Bugzilla bug 1982781, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz August 12, 2021 01:01
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@njhale
Copy link
Contributor Author

njhale commented Aug 12, 2021

/hold

investigating CI failures

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021
@njhale
Copy link
Contributor Author

njhale commented Aug 12, 2021

/hold cancel

still investigating flakes, but they seem to be unrelated

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit f62aaf3 into openshift:master Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@njhale: All pull requests linked via external trackers have merged:

Bugzilla bug 1982781 has been moved to the MODIFIED state.

In response to this:

Bug 1982781: fix(deprecate): explicit pkg rm drops latest deprecated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
@timflannagan
chore(docs): emphasize release versioning requirements (openshift#162)
d30d1fa 
Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: 242f6fd9ceef190bf9250e5ac431057a7f3f32b9
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
@timflannagan
chore(docs): emphasize release versioning requirements (openshift#162)
ad3f395 
Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: 242f6fd9ceef190bf9250e5ac431057a7f3f32b9
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
chore(docs): emphasize release versioning requirements (openshift#162)
d8a8354 
Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: 242f6fd9ceef190bf9250e5ac431057a7f3f32b9
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
@perdasilva
chore(docs): emphasize release versioning requirements (openshift#162)
5d88ec6 
Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: api
Upstream-commit: 242f6fd9ceef190bf9250e5ac431057a7f3f32b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 Awaiting requested review from anik120

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@ankitathomas ankitathomas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njhale @ankitathomas @exdx @openshift-bot