Skip to content

Bug 1989431: fix(opm): clarify that bundle declcfgs are not valid refs alone #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Aug 11, 2021

  • fix(opm): clarify that bundle declcfgs are not valid refs alone

Signed-off-by: Eric Stroczynski [email protected]

  • internal/action: changed ErrNotAllowed to variable for correct errors.Is() comparison

Signed-off-by: Eric Stroczynski [email protected]

Upstream-repository: operator-registry
Upstream-commit: 88d4d7633b93a73a2da2bd39348a8ba40b75db24

@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: This pull request references Bugzilla bug 1989431, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1989431: fix(opm): clarify that bundle declcfgs are not valid refs alone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 11, 2021
@openshift-ci openshift-ci bot requested review from awgreene and benluddy August 11, 2021 19:46
@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: An error was encountered querying GitHub for users with public email ([email protected]) for bug 1989431 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz
Copy link
Contributor Author

estroz commented Aug 11, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@estroz: This pull request references Bugzilla bug 1989431, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 11, 2021
@njhale
Copy link
Contributor

njhale commented Aug 12, 2021

/retest

@njhale
Copy link
Contributor

njhale commented Aug 12, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 12, 2021

/test e2e-gcp

@estroz
Copy link
Contributor Author

estroz commented Aug 12, 2021

/test e2e-upgrade

@estroz
Copy link
Contributor Author

estroz commented Aug 12, 2021

/test e2e-aws-olm

@estroz
Copy link
Contributor Author

estroz commented Aug 12, 2021

/retest

1 similar comment
@estroz
Copy link
Contributor Author

estroz commented Aug 12, 2021

/retest

@estroz
Copy link
Contributor Author

estroz commented Aug 13, 2021

/test e2e-upgrade

@estroz
Copy link
Contributor Author

estroz commented Aug 13, 2021

/cc @joelanford

@openshift-ci openshift-ci bot requested a review from joelanford August 13, 2021 06:43
@estroz
Copy link
Contributor Author

estroz commented Aug 13, 2021

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2021
* fix(opm): clarify that bundle declcfgs are not valid refs alone

Signed-off-by: Eric Stroczynski <[email protected]>

* internal/action: changed ErrNotAllowed to variable for correct errors.Is() comparison

Signed-off-by: Eric Stroczynski <[email protected]>

Upstream-repository: operator-registry
Upstream-commit: 88d4d7633b93a73a2da2bd39348a8ba40b75db24
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 16, 2021
@estroz
Copy link
Contributor Author

estroz commented Aug 17, 2021

/retest

1 similar comment
@estroz
Copy link
Contributor Author

estroz commented Aug 17, 2021

/retest

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@dinhxuanvu
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit fc5e9b5 into openshift:master Aug 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2021

@estroz: All pull requests linked via external trackers have merged:

Bugzilla bug 1989431 has been moved to the MODIFIED state.

In response to this:

Bug 1989431: fix(opm): clarify that bundle declcfgs are not valid refs alone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@estroz estroz deleted the bz/1989431 branch August 18, 2021 15:25
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
Upstream-repository: api
Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8
timflannagan pushed a commit to timflannagan/operator-framework-olm that referenced this pull request Nov 30, 2021
Upstream-repository: api
Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
Upstream-repository: api
Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 4, 2022
Upstream-repository: api
Upstream-commit: 37561c93045eee6044ae4748d3aea29fae5b09f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants