Skip to content

Bug 1996306: Update kubebuilder installation in the build root dockerfile #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timflannagan
Copy link
Contributor

Update the base.Dockerfile (the dockerfile specified in the build_root
stanza in the o/release ci-operator configuration) and ensure that
kubebuilder can be successfully installed.

The following errors were identified in recent e2e runs:

$ curl -L "https://go.kubebuilder.io/dl/${KUBEBUILDER_RELEASE}/${OS}/${ARCH}" | tar -xz -C /tmp/
...
Complete!
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    68  100    68    0     0    230      0 --:--:-- --:--:-- --:--:--   230

100 20604  100 20604    0     0  60958      0 --:--:-- --:--:-- --:--:-- 60958
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

When inspecting locally, the output file was HTML-based:

$ file ./kubebuilder
file kubebuilder
kubebuilder: HTML document, UTF-8 Unicode text, with very long lines

Replace the kubebuilder release URL to use the github release download
link, instead of the https://go.kubebuilder.io/dl domain.

Update the base.Dockerfile (the dockerfile specified in the `build_root`
stanza in the o/release ci-operator configuration) and ensure that
kubebuilder can be successfully installed.

The following errors were identified in recent e2e runs:

```bash
$ curl -L "https://go.kubebuilder.io/dl/${KUBEBUILDER_RELEASE}/${OS}/${ARCH}" | tar -xz -C /tmp/
...
Complete!
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    68  100    68    0     0    230      0 --:--:-- --:--:-- --:--:--   230

100 20604  100 20604    0     0  60958      0 --:--:-- --:--:-- --:--:-- 60958
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
```

When inspecting locally, the output file was HTML-based:

```bash
$ file ./kubebuilder
file kubebuilder
kubebuilder: HTML document, UTF-8 Unicode text, with very long lines
```

Replace the kubebuilder release URL to use the github release download
link, instead of the https://go.kubebuilder.io/dl domain.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2021
@timflannagan
Copy link
Contributor Author

Note: our o/release ci-operator configuration doesn't not testing build root dockerfile changes in a PR:

STEP 4: RUN yum install -y skopeo &&     export OS=$(go env GOOS) &&     export ARCH=$(go env GOARCH) &&     curl -L "https://go.kubebuilder.io/dl/${KUBEBUILDER_RELEASE}/${OS}/${ARCH}" | tar -xz -C /tmp/ &&     mv /tmp/kubebuilder_${KUBEBUILDER_RELEASE}_${OS}_${ARCH}/ /usr/local/kubebuilder &&     export PATH=$PATH:/usr/local/kubebuilder/bin &&     echo "Kubebuilder installation complete!"

Instead it defaults to building the HEAD version of this dockerfile, so we'll need to lgtm and override and failed tests.

@timflannagan timflannagan changed the title Update kubebuilder installation in the build root dockerfile Bug 1996306 : Update kubebuilder installation in the build root dockerfile Aug 21, 2021
@timflannagan timflannagan changed the title Bug 1996306 : Update kubebuilder installation in the build root dockerfile Bug 1996306" Update kubebuilder installation in the build root dockerfile Aug 21, 2021
@timflannagan timflannagan changed the title Bug 1996306" Update kubebuilder installation in the build root dockerfile Bug 1996306: Update kubebuilder installation in the build root dockerfile Aug 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@timflannagan: This pull request references Bugzilla bug 1996306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

Bug 1996306: Update kubebuilder installation in the build root dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 21, 2021
@openshift-ci openshift-ci bot requested a review from jianzhangbjz August 21, 2021 18:11
@timflannagan
Copy link
Contributor Author

/override ci/prow/verify
/override ci/prow/unit-registry
/override ci/prow/unit-api
/override ci/prow/unit-olm
/override ci/prow/images
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/images, ci/prow/unit-api, ci/prow/unit-olm, ci/prow/unit-registry, ci/prow/verify

In response to this:

/override ci/prow/verify
/override ci/prow/unit-registry
/override ci/prow/unit-api
/override ci/prow/unit-olm
/override ci/prow/images
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-aws-console-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davegord
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0ba8af9 into openshift:master Aug 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2021

@timflannagan: All pull requests linked via external trackers have merged:

Bugzilla bug 1996306 has been moved to the MODIFIED state.

In response to this:

Bug 1996306: Update kubebuilder installation in the build root dockerfile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants