Skip to content

Introduce the .ci-operator.yaml file #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Contributor

Allows us to control the build_root ci-operator configuration for
o/operator-framework-olm in the repository vs. in o/release. This allows
us to make changes to the build root Dockerfile (base.Dockerfile) and
have those changes get tested in the same PR. Previously, the build root
Dockerfile was always built using the HEAD version, which led to
situations where you would need to first merge (blindly) to master, then
open a PR to test those changes worked.

Allows us to control the build_root ci-operator configuration for
o/operator-framework-olm in the repository vs. in o/release. This allows
us to make changes to the build root Dockerfile (base.Dockerfile) and
have those changes get tested in the same PR. Previously, the build root
Dockerfile was always built using the HEAD version, which led to
situations where you would need to first merge (blindly) to master, then
open a PR to test those changes worked.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2021
@timflannagan
Copy link
Contributor Author

This doesn't affect e2e tests.

/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-olm, ci/prow/e2e-upgrade

In response to this:

This doesn't affect e2e tests.

/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e80f052 into openshift:master Sep 7, 2021
@timflannagan timflannagan deleted the update-build-root-config branch September 7, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants