-
Notifications
You must be signed in to change notification settings - Fork 71
Sync w/ upstream: operator-lifecycle-manager #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
e02906a
fix(og): Fix missing MultiOperatorGroups condition in some cases (#2305)
dinhxuanvu 011db68
Makefile: Add a linting target that runs gofmt/goimports
timflannagan b33b6b5
.github/workflows: Introduce a sanity check that runs static linting/…
timflannagan 5c83827
pkg,test: Fix linting violations in relevant packages
timflannagan afa6ef4
Update the CONTRIBUTING.md guidelines (#2344)
timflannagan eb55029
.github/workflows: Bump the docker/build-push-action to the v2 version
timflannagan 9674465
fail gracefully when client-ca file is not set or doesn't exist (#2358)
sjenning cb3b165
.github/workflows: Don't run the sanity jobs for markdown-only update…
timflannagan 25fb265
Makefile,test: Remove the test/rh-operators directory (#2354)
timflannagan 336f02e
Add summary and description for prometheus alerts (#2361)
tylerslaton fb8b572
test/e2e: Remove the unused e2e.sh and tap.jq files (#2366)
timflannagan 1023034
Add olm-managed label to configmap-based catalogsource for e2e test (…
dinhxuanvu 064c435
pkg/controller: Fix panic when creating cluster-scoped RBAC in OG con…
timflannagan e37e7d6
Update default catalog namespace (#2371)
kevinrizza 295c1dc
Integrate goreleaser to produce draft releases when new tags are push…
timflannagan 9941e12
Makefile: Update the e2e target to use ginkgo (#2367)
timflannagan 09bc475
test(e2e): use server-side apply to update fixture (#2385)
njhale 5cfd98e
fix: wrap subscription e2e test logic in Eventually statement (#2392)
exdx 26182b4
fix(e2e): Using Eventually to check subscription state (#2396)
dinhxuanvu fb8b0f4
fix(e2e): Remove the PreExistingCRDOwnerIsReplaced e2e test case (#2388)
dinhxuanvu 2f2caa4
Rename resolver/cache.Operator to Entry. (#2359)
benluddy baea59c
chore(make): add e2e test options (#2393)
njhale 5d23751
test/e2e: Wrap flake-prone garbage collection tests in eventually ass…
timflannagan 2248662
fix: wrap csv e2e test create in Eventually statements in the BeforeE…
exdx e37952b
fix: use v1 pdb object under e2e bundle test (#2398)
exdx bd29309
Improve reliability of e2e tests that include GRPC CatalogSources (#2…
awgreene 55508ed
Makefile: Update the e2e-local target and add CI-friendly ginkgo opti…
timflannagan a42e9b4
Expose pprof endpoint if tls is not configured (#2422)
awgreene 47d8f3c
Fix typo and add clarity to replacing transition (#2426)
perdasilva f7fdf89
Makefile: Explicitly override the default OLM install and test
timflannagan b575660
.github,test: Upload container logs during e2e runs as artifacts (#2432)
timflannagan a2f4723
test/e2e: Reduce subscription e2e test pollution (#2438)
timflannagan 4a0f091
test/e2e: Fix 'resource name may not be empty' failure in catalog tem…
timflannagan a6861ac
remove panic (#2448)
akihikokuroda a4147d8
fix(sub): Only update subscriptions that have changes in status (#2399)
dinhxuanvu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
staging/operator-lifecycle-manager/.github/workflows/goreleaser.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
name: release | ||
on: | ||
pull_request: | ||
push: | ||
tags: | ||
- 'v*' | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
- name: Set up Go | ||
uses: actions/setup-go@v2 | ||
with: | ||
go-version: 1.16 | ||
|
||
- name: Get the image tag | ||
if: startsWith(github.ref, 'refs/tags') | ||
run: | | ||
# Source: https://i.8713187.xyzmunity/t/how-to-get-just-the-tag-name/16241/32 | ||
if [[ $GITHUB_REF == refs/tags/* ]]; then | ||
echo IMAGE_TAG="${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV | ||
fi | ||
|
||
- name: Create a draft release | ||
uses: actions/create-release@v1 | ||
id: release | ||
if: startsWith(github.ref, 'refs/tags') | ||
env: | ||
GITHUB_TOKEN: ${{ github.token }} | ||
with: | ||
draft: true | ||
tag_name: ${{ github.ref }} | ||
release_name: ${{ github.ref }} | ||
|
||
- name: Docker Login | ||
uses: docker/login-action@v1 | ||
if: startsWith(github.ref, 'refs/tags') | ||
with: | ||
registry: quay.io | ||
username: ${{ secrets.QUAY_USERNAME }} | ||
password: ${{ secrets.QUAY_PASSWORD }} | ||
|
||
- name: Run GoReleaser | ||
uses: goreleaser/goreleaser-action@v2 | ||
if: startsWith(github.ref, 'refs/tags') | ||
with: | ||
version: 0.177.0 | ||
args: release --rm-dist | ||
env: | ||
GITHUB_TOKEN: ${{ github.token }} | ||
IMAGE_REPO: ${{ secrets.QUAY_USERNAME }}/olm | ||
PKG: github.com/operator-framework/operator-lifecycle-manager | ||
|
||
- name: Generate quickstart release manifests | ||
if: startsWith(github.ref, 'refs/tags') | ||
run: make release ver=${{ env.IMAGE_TAG }} IMAGE_REPO=quay.io/${{ secrets.QUAY_USERNAME }}/olm | ||
|
||
- name: Update release artifacts with rendered Kubernetes manifests | ||
uses: softprops/action-gh-release@v1 | ||
if: startsWith(github.ref, 'refs/tags') | ||
with: | ||
name: ${{ env.IMAGE_TAG }} | ||
files: | | ||
deploy/upstream/quickstart/crds.yaml | ||
deploy/upstream/quickstart/olm.yaml | ||
deploy/upstream/quickstart/install.sh | ||
draft: true | ||
token: ${{ github.token }} |
22 changes: 22 additions & 0 deletions
22
staging/operator-lifecycle-manager/.github/workflows/sanity.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: ci | ||
|
||
on: | ||
push: | ||
branches: | ||
- '**' | ||
pull_request: | ||
paths-ignore: | ||
- '**/*.md' | ||
|
||
jobs: | ||
sanity: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-go@v2 | ||
with: | ||
go-version: '~1.16' | ||
- name: Install goimports | ||
run: go install golang.org/x/tools/cmd/goimports@latest | ||
- name: Run sanity checks | ||
run: make vendor && make lint && make diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -455,3 +455,5 @@ apiserver.key | |
|
||
!vendor/** | ||
test/e2e-local.image.tar | ||
|
||
dist/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
env: | ||
- GO111MODULE=on | ||
- CGO_ENABLED=0 | ||
before: | ||
hooks: | ||
- go mod tidy | ||
- go mod vendor | ||
builds: | ||
- id: olm | ||
main: ./cmd/olm | ||
binary: olm | ||
goos: | ||
- linux | ||
goarch: | ||
- amd64 | ||
- arm64 | ||
- ppc64le | ||
- s390x | ||
tags: | ||
- json1 | ||
flags: | ||
- -mod=vendor | ||
ldflags: | ||
- -X {{ .Env.PKG }}/pkg/version.GitCommit={{ .FullCommit }} | ||
- -X {{ .Env.PKG }}/pkg/version.OLMVersion={{ .Tag }} | ||
- id: catalog | ||
main: ./cmd/catalog | ||
binary: catalog | ||
goos: | ||
- linux | ||
goarch: | ||
- amd64 | ||
- arm64 | ||
- ppc64le | ||
- s390x | ||
tags: | ||
- json1 | ||
flags: | ||
- -mod=vendor | ||
ldflags: | ||
- -X {{ .Env.PKG }}/pkg/version.GitCommit={{ .FullCommit }} | ||
- -X {{ .Env.PKG }}/pkg/version.OLMVersion={{ .Tag }} | ||
- id: cpb | ||
main: ./util/cpb | ||
binary: cpb | ||
goos: | ||
- linux | ||
goarch: | ||
- amd64 | ||
- arm64 | ||
- ppc64le | ||
- s390x | ||
tags: | ||
- json1 | ||
flags: | ||
- -mod=vendor | ||
ldflags: | ||
- -X {{ .Env.PKG }}/pkg/version.GitCommit={{ .FullCommit }} | ||
- -X {{ .Env.PKG }}/pkg/version.OLMVersion={{ .Tag }} | ||
- id: package-server | ||
main: ./cmd/package-server | ||
binary: package-server | ||
goos: | ||
- linux | ||
goarch: | ||
- amd64 | ||
- arm64 | ||
- ppc64le | ||
- s390x | ||
tags: | ||
- json1 | ||
flags: | ||
- -mod=vendor | ||
ldflags: | ||
- -X {{ .Env.PKG }}/pkg/version.GitCommit={{ .FullCommit }} | ||
- -X {{ .Env.PKG }}/pkg/version.OLMVersion={{ .Tag }} | ||
dockers: | ||
- image_templates: | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-amd64 | ||
dockerfile: Dockerfile.goreleaser | ||
use: buildx | ||
goos: linux | ||
goarch: amd64 | ||
build_flag_templates: | ||
- --platform=linux/amd64 | ||
- image_templates: | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-arm64 | ||
dockerfile: Dockerfile.goreleaser | ||
use: buildx | ||
goos: linux | ||
goarch: arm64 | ||
build_flag_templates: | ||
- --platform=linux/arm64 | ||
- image_templates: | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-ppc64le | ||
dockerfile: Dockerfile.goreleaser | ||
use: buildx | ||
goos: linux | ||
goarch: ppc64le | ||
build_flag_templates: | ||
- --platform=linux/ppc64le | ||
- image_templates: | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-s390x | ||
dockerfile: Dockerfile.goreleaser | ||
use: buildx | ||
goos: linux | ||
goarch: s390x | ||
build_flag_templates: | ||
- --platform=linux/s390x | ||
docker_manifests: | ||
- name_template: quay.io/{{ .Env.IMAGE_REPO }}:v{{ .Major }}.{{ .Minor }} | ||
image_templates: | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-amd64 | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-arm64 | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-ppc64le | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-s390x | ||
- name_template: quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }} | ||
image_templates: | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-amd64 | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-arm64 | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-ppc64le | ||
- quay.io/{{ .Env.IMAGE_REPO }}:{{ .Tag }}-s390x | ||
checksum: | ||
name_template: 'checksums.txt' | ||
snapshot: | ||
name_template: "{{ .Tag }}" | ||
changelog: | ||
sort: asc | ||
filters: | ||
exclude: | ||
- '^doc:' | ||
- '^test:' | ||
release: | ||
draft: true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll technically need to update o/release as well as we explicitly specify the
JUNIT_DIRECTORY
there. Likely easiest to drop this commit from this PR and tackle at a later date?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this was a breaking change then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I called it out when the PR was opened: operator-framework/operator-lifecycle-manager#2432 (comment) - imo it's a quick change and not the end of the world as we're between freezes right now and have the flexibility to make these types of changes.