[WIP] Add cluster runtime constraints handling #220
Conversation
Signed-off-by: Per G. da Silva <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @perdasilva. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
| @@ -0,0 +1,11 @@ | |||
| # Cluster Runtime Constraints | |||
There was a problem hiding this comment.
Does this belong in docs.go? i.e. looks like something we want in the go docs.
There was a problem hiding this comment.
Could you please be more specific for me: do you mean there's a docs place in this repo? do you mean upstream? do you mean docstrings in the code?
My intent here is to add developer documentation - just so people get the context of why that file exists there. Once we have the right way of doing things, then all of this should go away.
It is still my intention to add user facing docs though - but I was thinking of doing that in the upstream
There was a problem hiding this comment.
Sorry -- Go doc strings; e.g. https://github.com/kubernetes-sigs/controller-runtime/blob/master/doc.go autogenerates developer docs at https://pkg.go.dev/sigs.k8s.io/controller-runtime
| @@ -0,0 +1,11 @@ | |||
| # Cluster Runtime Constraints | |||
|
|
|||
| Cluster runtime constraints are base constraints that always get applied to the resolution process to avoid installing | |||
There was a problem hiding this comment.
It seems more apt to call it something like "global" or "static" than "cluster runtime", since this could be conflated with the "virtual bundle" concept mapped out in some of the EPs.
There was a problem hiding this comment.
damn - I see a lot of refactoring in my future now hahaha
There was a problem hiding this comment.
Please see operator-framework/operator-lifecycle-manager#2498 (review) for my thoughts on this.
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
@perdasilva: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Per G. da Silva [email protected]
Description
This the downstream component of the work being done in operator-framework/operator-lifecycle-manager#2498 to enable side loading of runtime constraints. Here, we add the runtime constratins file the operator image and update the olm catalog operator deployment manifest to include the environment variable (
RUNTIME_CONSTRAINTS), which points to the runtime constraints file in the local filesystem, and enables the feature