Skip to content

Sync api 10-12-2021 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 14, 2021

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Dec 10, 2021

No description provided.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Dec 10, 2021
camilamacedo86 and others added 4 commits December 10, 2021 14:35
Upstream-repository: api
Upstream-commit: 940ea901d140df5559af22c4ea094fe790a5258b
The community validator were deprecated.
This checks were moved to the external validator:
OCP OLM Catalog Validator

More info: https://github.com/redhat-openshift-ecosystem/ocp-olm-catalog-validator

Upstream-repository: api
Upstream-commit: eceda8b99fe0ad9e8b3ca91ee287c75f52fc898f
This commit updates the verify target to include the
format target as a prerequisite. This commit also
includes changes introduced after running the format
target.

Upstream-repository: api
Upstream-commit: 5678e585045db882c38cd186ace77d99c9fa0902
Signed-off-by: Per G. da Silva <[email protected]>

Upstream-repository: api
Upstream-commit: 822c9fe93cc0befb1c98da043662ecace5597f08
@anik120 anik120 force-pushed the sync-api-10-12-2021 branch from 3edd839 to c330e3b Compare December 10, 2021 19:41
@anik120
Copy link
Contributor Author

anik120 commented Dec 13, 2021

/retest

awgreene and others added 4 commits December 13, 2021 12:15
Upstream-repository: api
Upstream-commit: 17c661697c153dbb894fbe6213c2a5267dd378bc
Upstream-repository: api
Upstream-commit: af1f4d2d3638ff52af939623bc7c70be26efe1a1
* feat(cel): Add CEL custom library for semver comparison

Add CEL custom library for semver comparison to api repo. This
library is used in olm and registry.

Signed-off-by: Vu Dinh <[email protected]>

* Simplify the CEL library code structure

Remind the original cel package to constraints pkg to reflect that
there will be more type of constraints.

Remove the evaluator/provider interfaces that are not needed yet.
The generic interface can be designed later when a new type of
constraint is introduced.

Signed-off-by: Vu Dinh <[email protected]>

Upstream-repository: api
Upstream-commit: 1eb6c0266cce418b5f208d855d678174e02e5e55
Signed-off-by: Per G. da Silva <[email protected]>

Upstream-repository: api
Upstream-commit: 05f1dccfd0370126105e3ef3cb4f30604ee3d740
@anik120 anik120 force-pushed the sync-api-10-12-2021 branch from 6a50b1a to 5485c64 Compare December 13, 2021 17:15
@anik120
Copy link
Contributor Author

anik120 commented Dec 13, 2021

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 13, 2021
@anik120
Copy link
Contributor Author

anik120 commented Dec 13, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

@anik120: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e58ffe0 into openshift:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants