Bug 2026343: Address Invalid Address in GRPC Catalogs (#2499) #240

awgreene · 2022-01-05T21:49:05Z

Problem: Within the catalogSource resource, the RegistryServiceStatus
stores service information that is used to generate an address that OLM
relies on in order to establish a connection with the associated pod.
If the RegistryStatusService is not nil and is missing the namespace,
name, and port information for its service, OLM is unable to recover
until the catalogService's associated pod has an invalid image or
spec.

Solution: When reconciling a CatalogSource, OLM will now ensure that
the RegistryServiceStatus of the catalogSource is valid and will update
the catalogSource's status to reflect the change. Additionally, this
address is stored within the status of the catalogSource within the
status.GRPCConnectionState.Address field. If the address changes, OLM
will update this field to reflect the new address as well.

Signed-off-by: Alexander Greene [email protected]

Upstream-repository: operator-lifecycle-manager
Upstream-commit: cabe200bdabed1cb10c35cf434f7e426e3a8cb65

openshift-ci · 2022-01-05T21:51:11Z

@awgreene: This pull request references Bugzilla bug 2026343, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2026343: Address Invalid Address in GRPC Catalogs (#2499)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan

It looks like you need to run go mod vendor locally as we should see some root vendor directory changes in this PR as well.

awgreene · 2022-01-05T21:52:33Z

@timflannagan do I just amend that to the existing commit or do we separate that out?

timflannagan · 2022-01-05T21:54:24Z

@awgreene Yeah I'd just amend it to the existing commit.

Problem: Within the catalogSource resource, the RegistryServiceStatus stores service information that is used to generate an address that OLM relies on in order to establish a connection with the associated pod. If the RegistryStatusService is not nil and is missing the namespace, name, and port information for its service, OLM is unable to recover until the catalogService's associated pod has an invalid image or spec. Solution: When reconciling a CatalogSource, OLM will now ensure that the RegistryServiceStatus of the catalogSource is valid and will update the catalogSource's status to reflect the change. Additionally, this address is stored within the status of the catalogSource within the status.GRPCConnectionState.Address field. If the address changes, OLM will update this field to reflect the new address as well. Signed-off-by: Alexander Greene <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: cabe200bdabed1cb10c35cf434f7e426e3a8cb65

openshift-ci · 2022-01-05T21:57:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

timflannagan · 2022-01-05T22:00:42Z

/bugzilla refresh
/lgtm

openshift-ci · 2022-01-05T22:00:49Z

@timflannagan: This pull request references Bugzilla bug 2026343, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-01-06T00:20:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T00:32:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T03:57:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T04:21:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T08:01:02Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T08:26:59Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T11:15:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T14:42:09Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T15:34:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-06T17:05:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

timflannagan · 2022-01-06T17:29:17Z

Holding so the bot doesn't go crazy while we wait for the upgrades test to stabilize.

/hold

awgreene · 2022-01-19T23:53:07Z

/retest

awgreene · 2022-01-20T04:28:08Z

/retest

awgreene · 2022-01-20T15:04:17Z

/retest

kevinrizza · 2022-01-24T16:40:01Z

/retest

kevinrizza · 2022-01-24T16:42:53Z

/test e2e-aws-olm

awgreene · 2022-01-24T18:54:54Z

/test e2e-aws-olm

awgreene · 2022-01-24T21:17:10Z

/unhold
/retest

openshift-bot · 2022-01-25T00:42:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T01:54:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T02:55:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T05:31:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T08:31:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T10:45:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T11:10:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T14:09:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T14:22:49Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-25T16:58:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

awgreene · 2022-01-25T20:46:07Z

/retest

openshift-bot · 2022-01-25T21:57:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T00:26:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T02:02:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T03:51:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-26T06:41:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-26T08:40:21Z

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-26T08:40:45Z

@awgreene: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#240

Bugzilla bug 2026343 has been moved to the MODIFIED state.

In response to this:

Bug 2026343: Address Invalid Address in GRPC Catalogs (#2499)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Upstream-repository: api Upstream-commit: 8d4b21341834007272aba7809945348594bf703f

openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 5, 2022

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 5, 2022

timflannagan reviewed Jan 5, 2022

View reviewed changes

openshift-ci bot requested review from gallettilance and timflannagan January 5, 2022 21:54

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2022

awgreene force-pushed the grpc-address-bug-fix branch from bbfd159 to 12e83f9 Compare January 5, 2022 21:55

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 5, 2022

openshift-ci bot assigned timflannagan Jan 5, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2022

openshift-merge-robot merged commit d795a1d into openshift:master Jan 26, 2022

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jul 7, 2022

🌱 good practices validator nit clean up (openshift#240)

a8f44d5

Upstream-repository: api Upstream-commit: 8d4b21341834007272aba7809945348594bf703f

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jul 12, 2022

🌱 good practices validator nit clean up (openshift#240)

a574769

Upstream-repository: api Upstream-commit: 8d4b21341834007272aba7809945348594bf703f

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jul 13, 2022

🌱 good practices validator nit clean up (openshift#240)

f3c4766

Upstream-repository: api Upstream-commit: 8d4b21341834007272aba7809945348594bf703f

Bug 2026343: Address Invalid Address in GRPC Catalogs (#2499) #240

Bug 2026343: Address Invalid Address in GRPC Catalogs (#2499) #240

Uh oh!

Conversation

awgreene commented Jan 5, 2022

Uh oh!

openshift-ci bot commented Jan 5, 2022

Uh oh!

timflannagan left a comment

Choose a reason for hiding this comment

Uh oh!

awgreene commented Jan 5, 2022

Uh oh!

timflannagan commented Jan 5, 2022

Uh oh!

openshift-ci bot commented Jan 5, 2022

Uh oh!

timflannagan commented Jan 5, 2022

Uh oh!

openshift-ci bot commented Jan 5, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

openshift-bot commented Jan 6, 2022

Uh oh!

timflannagan commented Jan 6, 2022

Uh oh!

awgreene commented Jan 19, 2022

Uh oh!

awgreene commented Jan 20, 2022

Uh oh!

awgreene commented Jan 20, 2022

Uh oh!

kevinrizza commented Jan 24, 2022

Uh oh!

kevinrizza commented Jan 24, 2022

Uh oh!

awgreene commented Jan 24, 2022

Uh oh!

awgreene commented Jan 24, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022

Uh oh!

awgreene commented Jan 25, 2022

Uh oh!

openshift-bot commented Jan 25, 2022