Skip to content

Add perdasilva to OWNERS #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2022
Merged

Add perdasilva to OWNERS #241

merged 1 commit into from
Jan 22, 2022

Conversation

perdasilva
Copy link
Contributor

Signed-off-by: perdasilva [email protected]

Add me to the owners file

@perdasilva
Add perdasilva to OWNERS
4c4835a 
Signed-off-by: perdasilva <[email protected]>
@openshift-ci openshift-ci bot requested review from anik120 and njhale January 5, 2022 22:40
@timflannagan
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

Hi @perdasilva. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 5, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@timflannagan
Copy link
Contributor

Upgrade test appears to be permafailing - holding so the bot doesn't go crazy retesting.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@perdasilva
Copy link
Contributor Author

perdasilva commented Jan 14, 2022 •
edited
Loading

/verify-owners

@perdasilva
Copy link
Contributor Author

/retest-required

@joelanford
Copy link
Member

/override e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@joelanford: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-upgrade

Only the following contexts were expected:

  • ci/prow/e2e-aws-console-olm
  • ci/prow/e2e-aws-olm
  • ci/prow/e2e-gcp
  • ci/prow/e2e-upgrade
  • ci/prow/images
  • ci/prow/unit-api
  • ci/prow/unit-olm
  • ci/prow/unit-registry
  • ci/prow/verify
  • pull-ci-openshift-operator-framework-olm-master-e2e-aws-console-olm
  • pull-ci-openshift-operator-framework-olm-master-e2e-aws-olm
  • pull-ci-openshift-operator-framework-olm-master-e2e-gcp
  • pull-ci-openshift-operator-framework-olm-master-e2e-upgrade
  • pull-ci-openshift-operator-framework-olm-master-images
  • pull-ci-openshift-operator-framework-olm-master-unit-api
  • pull-ci-openshift-operator-framework-olm-master-unit-olm
  • pull-ci-openshift-operator-framework-olm-master-unit-registry
  • pull-ci-openshift-operator-framework-olm-master-verify
  • tide

In response to this:

/override e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford
Copy link
Member

/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-upgrade

In response to this:

/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford
Copy link
Member

/label bugzilla/valid-bug

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@joelanford: The label(s) /label bugzilla/valid-bug cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/label bugzilla/valid-bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford
Copy link
Member

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 21, 2022
@joelanford joelanford added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 21, 2022
@awgreene
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@joelanford
Copy link
Member

/override ci/prow/e2e-aws-olm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2022

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-aws-olm

In response to this:

/override ci/prow/e2e-aws-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3820d16 into openshift:master Jan 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2022

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jul 7, 2022
@camilamacedo86 @perdasilva
✨ (GoodPracticesValidator) : new check to warning that authors should…
2f38e3d 
… not create an operator to manage another operator by looking for RBAC permissions to create CRDs (openshift#241)

Upstream-repository: api
Upstream-commit: 05acd7a906c4819f1ad08203524e14b8a8ea4094
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jul 12, 2022
@camilamacedo86 @perdasilva
✨ (GoodPracticesValidator) : new check to warning that authors should…
28f20de 
… not create an operator to manage another operator by looking for RBAC permissions to create CRDs (openshift#241)

Upstream-repository: api
Upstream-commit: 05acd7a906c4819f1ad08203524e14b8a8ea4094
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jul 13, 2022
@camilamacedo86 @perdasilva
✨ (GoodPracticesValidator) : new check to warning that authors should…
3049432 
… not create an operator to manage another operator by looking for RBAC permissions to create CRDs (openshift#241)

Upstream-repository: api
Upstream-commit: 05acd7a906c4819f1ad08203524e14b8a8ea4094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anik120 anik120 Awaiting requested review from anik120

@njhale njhale Awaiting requested review from njhale

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@perdasilva @timflannagan @openshift-bot @joelanford @awgreene @openshift-merge-robot