Skip to content

Update the build root Dockerfile base image #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

timflannagan
Copy link
Contributor

Update the base.Dockerfile build root Dockerfile image, which the unit
and verify checks use as their base image, to use a Go 1.17 image.

Signed-off-by: timflannagan [email protected]

Update the base.Dockerfile build root Dockerfile image, which the unit
and verify checks use as their base image, to use a Go 1.17 image.

Signed-off-by: timflannagan <[email protected]>
@openshift-ci openshift-ci bot requested review from benluddy and joelanford March 2, 2022 00:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2022
@perdasilva
Copy link
Contributor

/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-upgrade

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/e2e-aws-olm, ci/prow/e2e-upgrade

In response to this:

/override ci/prow/e2e-aws-olm
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2022

@timflannagan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 99d2f8c into openshift:master Mar 2, 2022
@timflannagan timflannagan deleted the ci/bump-base-dockerfile-go-version branch March 2, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants