Skip to content

Fix install_kubebuilder.sh script #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix install_kubebuilder.sh script #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/install_kubebuilder.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,18 @@ KUBEBUILDER_BIN=${KUBEBUILDER_BIN:=/usr/local/kubebuilder}
OS=$(go env GOOS)
ARCH=$(go env GOARCH)
KUBEBUILDER_RELEASE=2.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this URL change is only valid for 3.0.0+ so this line would need to change. https://github.com/kubernetes-sigs/kubebuilder/releases/download/v3.3.0/kubebuilder_linux_amd64 works but for 2.3.1 it's https://github.com/kubernetes-sigs/kubebuilder/releases/download/v2.3.1/kubebuilder_2.3.1_linux_amd64.tar.gz (an extra version in the name + the tar.gz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's basically the change I've made. I've put a note to say that from 3.0.0+ the url wouldn't work. This is to unblock CI. Once this is through I can look at upping the version to 3.0.0 as a different issue. wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL @perdasilva is using seems to work as it is, the new format for 3.0.0+ versions is commented out.

KUBEBUILDER_DOWNLOAD_URL="https://github.com/kubernetes-sigs/kubebuilder/releases/download/v${KUBEBUILDER_RELEASE}/kubebuilder_${KUBEBUILDER_RELEASE}_${OS}_${ARCH}.tar.gz"

# Note: From v3.0.0+ the release assets in the kubebuilder repo change format
# See: https://github.com/kubernetes-sigs/kubebuilder/releases
# KUBEBUILDER_DOWNLOAD_URL="https://github.com/kubernetes-sigs/kubebuilder/releases/download/v${KUBEBUILDER_RELEASE}/kubebuilder_${OS}_${ARCH}"

if [[ -d ${KUBEBUILDER_BIN} ]]; then
echo "Not installing kubebuilder as the binary already exists in \$PATH"
exit 0
fi

curl -L "https://go.kubebuilder.io/dl/${KUBEBUILDER_RELEASE}/${OS}/${ARCH}" | tar -xz -C /tmp/ && \
curl -L ${KUBEBUILDER_DOWNLOAD_URL} | tar -xz -C /tmp/ && \
mv /tmp/kubebuilder_${KUBEBUILDER_RELEASE}_${OS}_${ARCH}/ /usr/local/kubebuilder

echo "Kubebuilder installation complete!"
Expand Down