sync: Update staging directories 04-05 #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: ac3aa278ddc8d59add546bf9e33e583f17d62bb0
The thread-safety logic is flawed and can prevent Operator resources from being reconciled when component resources are updated. It also ensures idempotence when enqueuing a resource for reconciliation; In other words, enqueuing no-ops if the given resource is already in the queue. The underlying queue will ensure a reconciler never races itself when processing a given resource event. Signed-off-by: Nick Hale <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 3807cc1a01619ddf857009c72ca1712746e8fc01
Signed-off-by: Anik Bhattacharjee <[email protected]> Upstream-repository: operator-registry Upstream-commit: b4264e2bfdf9045f79d359c0b09d2b5ffffe620e
While generating a diff from a catalog that has operators that specify dependencies that are cyclic in nature, eg a->b, b->a, the `opm alpha diff` command hangs. This was happening because while generating the diff, the command does a breadth-first search of the dependency graph generated by the operator bundles, but did not keep a track of the already visited bundles. As a result, when there was a cycle in the dependency graph, the command was stuck in an infinite loop. This PR fixes the issue by keeping track of the already visited bundles during the search, and moving the search forward with only the bundles that haven't been visited before. Fixes openshift#936 Signed-off-by: Anik Bhattacharjee <[email protected]> Upstream-repository: operator-registry Upstream-commit: de36104087733013025629d80bf8445045a8a6e7
* fix: check for warning when the channel naming does not follow the convention * applying nit suggestions * fix-channel-check * adressing nit review Upstream-repository: api Upstream-commit: f718c911ae218fa4362ee60670b6dfc6503a6388
This adds a check to the good practices validator that ensures all CRDs declared in the bundle have non-empty descriptions. Both owned and required CRDs will be checked. Note that this validates the CRD definition in the CSV, not any field in the CRD itself. Signed-off-by: Ryan King <[email protected]> Upstream-repository: api Upstream-commit: a7ebc81c9577a300814448a901edae74c6e6e44e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/retest0required |
|
/lgtm |
Looking at both of those package-server replica logs, it's unclear to me what's the root cause there. |
|
/override ci/prow/e2e-gcp |
|
@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@timflannagan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.10 |
|
@tylerslaton: #278 failed to apply on top of branch "release-4.10": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all of the staging directories with the changes that have landed since the initial u/d sync PR.