Skip to content

Bug 2095329: [release-4.10] Bump go to v1.17 (#922) #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

perdasilva
Copy link
Contributor

This commit updates the operator-registry's go version
to v1.17.

Signed-off-by: Alexander Greene [email protected]
Upstream-repository: operator-registry
Upstream-commit: c970d617ce2d77c096102e2d881a15ef680bacf9

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@perdasilva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.10] Bump go to v1.17 (#922)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva perdasilva changed the title [release-4.10] Bump go to v1.17 (#922) Bug 2083919: [release-4.10] Bump go to v1.17 (#922) May 27, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@perdasilva: This pull request references Bugzilla bug 2083919, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "---" instead
  • expected Bugzilla bug 2083919 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2083919: [release-4.10] Bump go to v1.17 (#922)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ankitathomas and njhale May 27, 2022 15:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@perdasilva
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@perdasilva: This pull request references Bugzilla bug 2083919, which is invalid:

  • expected Bugzilla bug 2083919 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2022

@openshift-bot: This pull request references Bugzilla bug 2083919, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "---" instead
  • expected Bugzilla bug 2083919 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2022

@openshift-bot: This pull request references Bugzilla bug 2083919, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "---" instead
  • expected Bugzilla bug 2083919 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

@openshift-bot: This pull request references Bugzilla bug 2083919, which is invalid:

  • expected the bug to target the "4.10.z" release, but it targets "---" instead
  • expected Bugzilla bug 2083919 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva perdasilva force-pushed the operator-registry-go-bump branch from 8ecb2d1 to c88dcc6 Compare May 30, 2022 06:57
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@perdasilva perdasilva force-pushed the operator-registry-go-bump branch 3 times, most recently from cc8120c to fc86d73 Compare May 30, 2022 08:51
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@perdasilva perdasilva force-pushed the operator-registry-go-bump branch from fc86d73 to 7f8ad59 Compare May 30, 2022 09:18
@perdasilva perdasilva closed this May 30, 2022
@perdasilva perdasilva force-pushed the operator-registry-go-bump branch from 7f8ad59 to 1a99acb Compare May 30, 2022 09:19
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@perdasilva perdasilva reopened this May 30, 2022
@jianzhangbjz
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@jianzhangbjz: This pull request references Bugzilla bug 2083919, which is invalid:

  • expected Bugzilla bug 2083919 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bandrade
Copy link
Contributor

bandrade commented Jun 6, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 6, 2022
@timflannagan
Copy link
Contributor

It looks like we don't have a 4.11 parent BZ, so we'll need to retarget the referenced BZ to 4.11 and verify that first before we can start the backport process to the release-4.10 branch.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@perdasilva
Copy link
Contributor Author

It looks like we don't have a 4.11 parent BZ, so we'll need to retarget the referenced BZ to 4.11 and verify that first before we can start the backport process to the release-4.10 branch.

/hold

Does that make sense though? 4.11 is already on go1.17

@timflannagan
Copy link
Contributor

I think the intention is to make sure the proper backport chain has been followed, and in cases like this it doesn't make much sense as 4.11 is already on Go 1.17, and so we'd need to either flip a 4.11 BZ to MODIFIED/ON_QA/VERIFIED and create a cherry-pick 4.10 BZ here in order to make the BZ bot, or we'd have someone override that valid-bug label.

@perdasilva
Copy link
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 9, 2022
@perdasilva perdasilva changed the title Bug 2083919: [release-4.10] Bump go to v1.17 (#922) Bug 2095329: [release-4.10] Bump go to v1.17 (#922) Jun 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@perdasilva: This pull request references Bugzilla bug 2095329, which is invalid:

  • expected dependent Bugzilla bug 2083919 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2095329: [release-4.10] Bump go to v1.17 (#922)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

/hold cancel
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 9, 2022
@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@openshift-bot: This pull request references Bugzilla bug 2095329, which is invalid:

  • expected dependent Bugzilla bug 2083919 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@jianzhangbjz: This pull request references Bugzilla bug 2095329, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.z) matches configured target release for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2083919 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2083919 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

/label cherry-pick-approved

@openshift-merge-robot openshift-merge-robot merged commit c10b001 into openshift:release-4.10 Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@perdasilva: All pull requests linked via external trackers have merged:

Bugzilla bug 2095329 has been moved to the MODIFIED state.

In response to this:

Bug 2095329: [release-4.10] Bump go to v1.17 (#922)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@perdasilva: Bugzilla bug 2095329 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Jan 11, 2024
Signed-off-by: Joe Lanford <[email protected]>
Upstream-repository: api
Upstream-commit: 0d032b99c9cf9b73445ad9f5f46485d58a39a7e9
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jan 16, 2024
Signed-off-by: Joe Lanford <[email protected]>
Upstream-repository: api
Upstream-commit: 0d032b99c9cf9b73445ad9f5f46485d58a39a7e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants