OPRUN-2892: Update service-monitor tls config #368
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@xueqzhan should this change also live in the upstream? If so, we should make the changes there and then bring them downstream. |
|
/hold waiting from review and input from @xueqzhan |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
That is a very good question. @deads2k Can you answer that? @perdasilva As it turned out, the current kube-rbac-proxy is not coded/configured to properly updating client CA. I am in the process of fixing it. Merging this change in will not hard anything. But the feature will not work until the kube-rbac-proxy fix is in. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
The CSR approver that allows the prometheus scraper to generate its own client certificate only exists in OCP, so I don't think this would function properly upstream. |
|
/retest |
1 similar comment
|
/retest |
|
/retest ci/prow/e2e-gcp |
|
/test e2e-gcp |
|
@perdasilva: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@perdasilva: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-gcp |
|
@perdasilva: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all |
|
/override ci/prow/e2e-gcp |
|
@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-gcp-olm |
|
Failed at: test resources deleted
�[38;5;243m<< End Captured GinkgoWriter Output�[0m
�[38;5;9m
Error Trace: /go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/operator_groups_e2e_test.go:1562
/go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/suite.go:605
/go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/asm_amd64.s:1594
Error: Received unexpected error:
timed out waiting for the condition
Test: Operator Group CSV copy watching all namespaces
�[0m |
|
/test e2e-gcp-olm |
|
/retest |
|
/hold Revision 4af508d was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-upgrade |
|
/retest |
|
/remove-label docs-approved |
openshift-ci
bot
removed
the
docs-approved
|
/remove-label px-approved |
openshift-ci
bot
removed
the
px-approved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
Met this issue again https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_operator-framework-olm/368/pull-ci-openshift-operator-framework-olm-master-e2e-gcp-olm/1641035776055578624/artifacts/e2e-gcp-olm/test/build-log.txt. The PR operator-framework/operator-lifecycle-manager#2946 fixed it. �[38;5;9m
Error Trace: /go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/operator_groups_e2e_test.go:1562
/go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/suite.go:605
/go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/asm_amd64.s:1594
Error: Received unexpected error:
timed out waiting for the condition
Test: Operator Group CSV copy watching all namespaces
�[0m
�[38;5;9mIn �[1m[It]�[0m�[38;5;9m at: �[1m/go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1261�[0m
�[38;5;9mFull Stack Trace�[0m |
|
/test e2e-gcp-olm |
|
/retest |
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The client cert/key pair is a way of authenticating that will function even without live kube-apiserver connections so we can collect metrics if the kube-apiserver is unavailable.
Signed-off-by: perdasilva [email protected]