Skip to content

OLM-2695: Adds downstream only CSV Namespace Labeler Plug-In #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2022
Merged

OLM-2695: Adds downstream only CSV Namespace Labeler Plug-In #370

merged 4 commits into from
Sep 12, 2022

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Aug 23, 2022 •
edited
Loading

Description

This PR adds the downstream only csv namespace labeler olm controller plug-in. This plug-in adds an additional csv queue informer with a sync method that when a csv is updated/created labels the csv namespace with security.openshift.io/scc.podSecurityLabelSync=true if:

  • the namespace is not part of the payload, unless it is openshift-operators
  • the namespace is not already labelled with the label above (whether true or false)
  • the namespace name is prefixed with openshift-

The csv informer ignores copied csvs and prunes out the body of the csv (save for the metadata section) to be frugal on memory.

NOTE: because this is a downstream only change, it makes changes to the staging directory. Because of this the verify job will fail - as it checks that there are no staging directory changes outside of what is brought in from the upstream.

@perdasilva
Copy link
Contributor Author

perdasilva commented Aug 23, 2022 •
edited
Loading

/hold don't merge until we have the qe-approved label

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@openshift-ci openshift-ci bot requested review from anik120 and joelanford August 23, 2022 10:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@perdasilva
Copy link
Contributor Author

/retest

@perdasilva perdasilva force-pushed the csv_ns_labeler_plugin branch from 12c644d to 052ba18 Compare August 23, 2022 11:40
@perdasilva perdasilva changed the title Adds downstream only CSV Namespace Labeler Plug-In [WIP] Adds downstream only CSV Namespace Labeler Plug-In Aug 23, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2022
@perdasilva
Copy link
Contributor Author

/retest

@perdasilva perdasilva force-pushed the csv_ns_labeler_plugin branch 6 times, most recently from eaa700c to f2a484d Compare August 24, 2022 11:30
@perdasilva perdasilva changed the title [WIP] Adds downstream only CSV Namespace Labeler Plug-In [WIP] OLM-2695: Adds downstream only CSV Namespace Labeler Plug-In Aug 24, 2022
@perdasilva perdasilva force-pushed the csv_ns_labeler_plugin branch 4 times, most recently from 5bb3d6d to df36664 Compare August 25, 2022 17:33
@perdasilva perdasilva force-pushed the csv_ns_labeler_plugin branch from df36664 to dd8fbfd Compare August 30, 2022 07:43
@perdasilva perdasilva changed the title [WIP] OLM-2695: Adds downstream only CSV Namespace Labeler Plug-In OLM-2695: Adds downstream only CSV Namespace Labeler Plug-In Aug 30, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2022
@perdasilva perdasilva force-pushed the csv_ns_labeler_plugin branch 5 times, most recently from ad68b2c to 47bee61 Compare August 31, 2022 07:42
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2149aeb and 1 for PR HEAD 41f2be2 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2022
@perdasilva perdasilva force-pushed the csv_ns_labeler_plugin branch from 41f2be2 to d4643bc Compare September 8, 2022 10:14
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2022
@perdasilva
Add olm operator plug-in framework (#2843)
3f3937b 
Signed-off-by: perdasilva <[email protected]>

Signed-off-by: perdasilva <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 35c5af2a46fd60a2e7eb9777815ab52063d67a02
@perdasilva
Import cluster-policy-controller into operator-lifecycle-manager
c3671cb 
Signed-off-by: perdasilva <[email protected]>
@perdasilva
Add CSV Namespace Plug-In
0c6ce57 
Signed-off-by: perdasilva <[email protected]>
@perdasilva
Update dependencies and vendor directory
9ba1819 
Signed-off-by: perdasilva <[email protected]>
@perdasilva perdasilva force-pushed the csv_ns_labeler_plugin branch from d4643bc to 9ba1819 Compare September 8, 2022 10:54
@perdasilva
Copy link
Contributor Author

/retest

@perdasilva
Copy link
Contributor Author

verify is failing due to changes in the staging directory. This is expected since the downstream only changes are made in there.

@perdasilva
Copy link
Contributor Author

/override ci/prow/verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

@perdasilva: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [perdasilva,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Contributor Author

/override ci/prow/verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

@perdasilva: Overrode contexts on behalf of perdasilva: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 97782e6 and 2 for PR HEAD 9ba1819 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7bc5831 into openshift:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentito bentito bentito left review comments

@jianzhangbjz jianzhangbjz jianzhangbjz left review comments

@timflannagan timflannagan timflannagan approved these changes

@anik120 anik120 Awaiting requested review from anik120

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@oceanc80 oceanc80

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@perdasilva @jianzhangbjz @oceanc80 @timflannagan @openshift-ci-robot @bentito @openshift-merge-robot