-
Notifications
You must be signed in to change notification settings - Fork 72
OLM-2726, OCPBUGS-643: downstreaming opm serve
changes from operator-registry
#374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When we fatally exit directly in the serve functions, we do not give a chance for the registered cleanup functions to run, resulting in temporary files being left behind. This commit ensures that we always cleanly return an error from the serve function, thus ensuring that defered cleanups always happen. Signed-off-by: Joe Lanford <[email protected]> Upstream-repository: operator-registry Upstream-commit: 215f413e76e3fb544b0d450acdbab41c756dbf59
* opm serve: use pre-existing cache, if set and up-to-date Signed-off-by: Joe Lanford <[email protected]> * refactor to leave NewQuerier function untouched Signed-off-by: Joe Lanford <[email protected]> Upstream-repository: operator-registry Upstream-commit: 215f413e76e3fb544b0d450acdbab41c756dbf59
/retest-required |
/jira refresh |
/hold for qe-review |
Hi, @grokspawn |
* fix permissions problems with pregen cache access * constant replacement Signed-off-by: Jordan <[email protected]> Upstream-repository: operator-registry Upstream-commit: ce3bb44f7618726474a78f95852e30a2bfb0346a
opm serve
changes from operator-registryopm serve
changes from operator-registry
@grokspawn: This pull request references Jira Issue OCPBUGS-650, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@grokspawn: This pull request references Jira Issue OCPBUGS-650, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I included the upstream fix for the related bug in this since the functionality is a logical whole. |
opm serve
changes from operator-registryopm serve
changes from operator-registry
@grokspawn: This pull request references Jira Issue OCPBUGS-643, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@grokspawn: This pull request references Jira Issue OCPBUGS-643, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@grokspawn: This pull request references Jira Issue OCPBUGS-643, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@grokspawn: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label qe-approved |
/hold for qe-review |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@grokspawn: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-643 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.11 |
@grokspawn: #374 failed to apply on top of branch "release-4.11":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bumps [github.com/google/cel-go](https://github.com/google/cel-go) from 0.22.0 to 0.22.1. - [Release notes](https://github.com/google/cel-go/releases) - [Commits](google/cel-go@v0.22.0...v0.22.1) --- updated-dependencies: - dependency-name: github.com/google/cel-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: 47eb57aabb155b9c71627c7117ffeab650ae5b9d
including two commits which seem to be of equal priority to pipeline: