Bug OCPBUGS-828: backport `opm serve` caching functionality (and bugfix) + `opm serve` leaving orphan tmpfiles #375

grokspawn · 2022-09-01T19:35:05Z

No description provided.

openshift-ci · 2022-09-01T19:35:11Z

@grokspawn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OLM-2750: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

grokspawn · 2022-09-01T19:35:23Z

/hold for qe-review

openshift-ci · 2022-09-01T19:43:06Z

@grokspawn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug OLM-2750: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-09-01T20:17:53Z

@grokspawn: This pull request references Jira Issue OCPBUGS-828, which is invalid:

expected the bug to target the "4.11.z" version, but no target version was set
expected Jira Issue OCPBUGS-828 to depend on a bug targeting a version in 4.12.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-09-01T20:18:09Z

@grokspawn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug OCPBUGS-828: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-09-01T20:20:48Z

@grokspawn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

grokspawn · 2022-09-01T20:21:28Z

/jira refresh

openshift-ci-robot · 2022-09-01T20:21:31Z

@grokspawn: This pull request references Jira Issue OCPBUGS-828, which is invalid:

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug OLM-2726 is not in the required OCPBUGS project

All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:

Create a new bug in the OCPBUGS Jira project to match the original bugzilla bug. The important fields that should match are the title, description, target version, and status.
Use the Jira UI to clone the Jira bug, then in the clone bug:
a. Set the target version to the release you are cherrypicking to.
b. Add an issue link “is blocked by”, which links to the original jira bug
Use the cherrypick github command to create the cherrypicked PR. Once that new PR is created, retitle the PR and replace the BUG XXX: with OCPBUGS-XXX: to match the new Jira story.

Note that the mirrored bug in OCPBUGSM should not be involved in this process at all.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

grokspawn · 2022-09-01T20:34:37Z

/jira refresh

openshift-ci-robot · 2022-09-01T20:34:40Z

@grokspawn: This pull request references Jira Issue OCPBUGS-828, which is invalid:

expected dependent Jira Issue OCPBUGS-829 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed instead
expected dependent Jira Issue OCPBUGS-829 to target a version in 4.12.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

grokspawn · 2022-09-01T20:36:32Z

/jira refresh

openshift-ci-robot · 2022-09-01T20:36:39Z

@grokspawn: This pull request references Jira Issue OCPBUGS-828, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-829 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-829 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

When we fatally exit directly in the serve functions, we do not give a chance for the registered cleanup functions to run, resulting in temporary files being left behind. This commit ensures that we always cleanly return an error from the serve function, thus ensuring that defered cleanups always happen. Signed-off-by: Joe Lanford <[email protected]> Upstream-repository: operator-registry Upstream-release-repository: release-4.12 Upstream-commit: 90c49bc

* opm serve: use pre-existing cache, if set and up-to-date Signed-off-by: Joe Lanford <[email protected]> * refactor to leave NewQuerier function untouched Signed-off-by: Joe Lanford <[email protected]> Upstream-repository: operator-registry Upstream-release: 4.12 Upstream-commit: b94e073

* fix permissions problems with pregen cache access * constant replacement Signed-off-by: Jordan <[email protected]> Upstream-repository: operator-registry Upstream-release: 4.12 Upstream-commit: aec6a49

Xia-Zhao-rh · 2022-09-02T03:44:08Z

/label cherry-pick-approved
/label qe-approved

grokspawn · 2022-09-02T12:19:11Z

/retest-required

grokspawn · 2022-09-02T12:19:43Z

/test e2e-gcp-olm-flaky

grokspawn · 2022-09-02T14:44:40Z

/retest-required

timflannagan · 2022-09-02T14:44:51Z

go.mod

-	google.golang.org/grpc v1.43.0 // indirect
+	google.golang.org/grpc v1.45.0 // indirect


Just for others: It looks like we still correctly replace pin this grpc package due to OLM issues in the vendor/modules.txt.

openshift-ci · 2022-09-02T15:00:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-09-02T16:50:29Z

@grokspawn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-olm-flaky	`8149337`	link	false	`/test e2e-gcp-olm-flaky`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

awgreene · 2022-09-02T20:24:15Z

This performance improvement needs to be backported because the default catalogs are constantly failing their readiness and liveness in 4.11 clusters.

/label backport-risk-assessed

grokspawn · 2022-09-02T20:30:18Z

/hold cancel
We have cherry-pick-approved, qe-approved, backport-risk-assessed

openshift-ci-robot · 2022-09-02T20:33:50Z

@grokspawn: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#375

Jira Issue OCPBUGS-828 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: 6c143112915ad0122b160c3198e7c93c4c96ff0a

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022

openshift-ci bot requested review from anik120 and exdx September 1, 2022 19:36

grokspawn changed the title ~~OLM-2750: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles~~ Bug OLM-2750: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles Sep 1, 2022

grokspawn changed the title ~~Bug OLM-2750: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles~~ Bug OCPBUGS-828: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles Sep 1, 2022

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Sep 1, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 1, 2022

openshift-ci bot requested a review from Xia-Zhao-rh September 1, 2022 20:36

joelanford and others added 3 commits September 1, 2022 16:03

(bug) fix permissions problems with pregen cache access (#1018)

8149337

* fix permissions problems with pregen cache access * constant replacement Signed-off-by: Jordan <[email protected]> Upstream-repository: operator-registry Upstream-release: 4.12 Upstream-commit: aec6a49

openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Sep 2, 2022

timflannagan approved these changes Sep 2, 2022

View reviewed changes

openshift-ci bot assigned timflannagan Sep 2, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 2, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022

openshift-merge-robot merged commit 66cc4fd into openshift:release-4.11 Sep 2, 2022

grokspawn deleted the opm-caching branch September 2, 2022 20:34

perdasilva mentioned this pull request Jan 15, 2025

NO-ISSUE: Manual Synchronize From Upstream Repositories #933

Merged

		google.golang.org/grpc v1.43.0 // indirect
		google.golang.org/grpc v1.45.0 // indirect

Bug OCPBUGS-828: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles #375

Bug OCPBUGS-828: backport opm serve caching functionality (and bugfix) + opm serve leaving orphan tmpfiles #375

Uh oh!

Conversation

grokspawn commented Sep 1, 2022

Uh oh!

openshift-ci bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grokspawn commented Sep 1, 2022

Uh oh!

openshift-ci bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 1, 2022

Uh oh!

openshift-ci bot commented Sep 1, 2022

Uh oh!

openshift-ci bot commented Sep 1, 2022

Uh oh!

grokspawn commented Sep 1, 2022

Uh oh!

openshift-ci-robot commented Sep 1, 2022 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grokspawn commented Sep 1, 2022

Uh oh!

openshift-ci-robot commented Sep 1, 2022

Uh oh!

grokspawn commented Sep 1, 2022

Uh oh!

openshift-ci-robot commented Sep 1, 2022

Uh oh!

Xia-Zhao-rh commented Sep 2, 2022

Uh oh!

grokspawn commented Sep 2, 2022

Uh oh!

grokspawn commented Sep 2, 2022

Uh oh!

grokspawn commented Sep 2, 2022

Uh oh!

timflannagan Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Sep 2, 2022

Uh oh!

openshift-ci bot commented Sep 2, 2022

Uh oh!

awgreene commented Sep 2, 2022

Uh oh!

grokspawn commented Sep 2, 2022

Uh oh!

openshift-ci-robot commented Sep 2, 2022

Uh oh!

Uh oh!

Bug OCPBUGS-828: backport `opm serve` caching functionality (and bugfix) + `opm serve` leaving orphan tmpfiles #375

Bug OCPBUGS-828: backport `opm serve` caching functionality (and bugfix) + `opm serve` leaving orphan tmpfiles #375

openshift-ci bot commented Sep 1, 2022 •

edited

Loading

openshift-ci bot commented Sep 1, 2022 •

edited

Loading

openshift-ci-robot commented Sep 1, 2022 •

edited by openshift-ci bot

Loading

timflannagan Sep 2, 2022 •

edited

Loading