Skip to content

OLM-2753: Semver veneer pipe support #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2022
Merged

OLM-2753: Semver veneer pipe support #376

merged 2 commits into from
Sep 7, 2022

Conversation

grokspawn
Copy link
Contributor

downstreaming this upstream functionality

@openshift-ci openshift-ci bot requested review from anik120 and exdx September 2, 2022 13:28
@grokspawn
Copy link
Contributor Author

/hold for qe-review

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022
@oceanc80 @grokspawn
Add pipe support to opm alpha render-veneer semver (#1015)
c28533b 
Signed-off-by: Catherine Chan-Tse <[email protected]>
Upstream-commit: 166ed6b607a412f955dcc2b7293b9e338eaae5ae
Upstream-repository: operator-registry
@oceanc80 @grokspawn
Addressing additional feedback from PR 1015 (#1017)
a116104 
Signed-off-by: Catherine Chan-Tse <[email protected]>
Upstream-commit: 856f0bcd161dfb420cabdc8b2896f78f49dbb3d4
Upstream-repository: operator-registry
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@grokspawn
Copy link
Contributor Author

/test ci/prow/e2e-gcp-olm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

@grokspawn: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-gcp-console-olm
  • /test e2e-gcp-olm
  • /test e2e-gcp-ovn
  • /test e2e-upgrade
  • /test images
  • /test unit-api
  • /test unit-olm
  • /test unit-psm
  • /test unit-registry
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-gcp-olm-flaky

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-gcp-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Contributor Author

grokspawn commented Sep 2, 2022 •
edited
Loading

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2022

@grokspawn: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-gcp-console-olm
  • /test e2e-gcp-olm
  • /test e2e-gcp-ovn
  • /test e2e-upgrade
  • /test images
  • /test unit-api
  • /test unit-olm
  • /test unit-psm
  • /test unit-registry
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-gcp-olm-flaky

Use /test all to run all jobs.

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm

@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

1 similar comment
@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm-flaky

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Xia-Zhao-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 7, 2022
@Xia-Zhao-rh
Copy link

/cancel hold

@Xia-Zhao-rh
Copy link

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7bdddd9 into openshift:master Sep 7, 2022
@grokspawn grokspawn deleted the semver-veneer-pipe-support branch September 7, 2022 08:53
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jan 15, 2025
@dependabot
Bump k8s.io/apiextensions-apiserver from 0.31.2 to 0.31.3 (openshift#376
1586216 
)

Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.31.2 to 0.31.3.
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.31.2...v0.31.3)

---
updated-dependencies:
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: eae0d6a80f5cb436fb75f74c499550f93c948cba
@perdasilva perdasilva mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan approved these changes

@anik120 anik120 Awaiting requested review from anik120

@exdx exdx Awaiting requested review from exdx

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grokspawn @Xia-Zhao-rh @timflannagan @openshift-merge-robot @oceanc80