Skip to content

OCPBUGS-650: fixing reliance on candidate channel containing all referenced bundle… #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

grokspawn
Copy link
Contributor

…s (#1009)

Signed-off-by: Jordan Keister [email protected]
Upstream-commit: 52e35f0291529290363e0e2d23d5b0c1524103c1
Upstream-repository: operator-registry

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2022
@grokspawn
Copy link
Contributor Author

/jira refresh

@grokspawn grokspawn changed the title OCPBUGS-650 fixing reliance on candidate channel containing all referenced bundle… OCPBUGS-650: fixing reliance on candidate channel containing all referenced bundle… Sep 7, 2022
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 7, 2022
@openshift-ci-robot
Copy link

@grokspawn: This pull request references Jira Issue OCPBUGS-650, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

…s (#1009)

Signed-off-by: Jordan Keister [email protected]
Upstream-commit: 52e35f0291529290363e0e2d23d5b0c1524103c1
Upstream-repository: operator-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fceaf8a and 2 for PR HEAD 1e25545 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2022
#1009)

Signed-off-by: Jordan Keister <[email protected]>
Upstream-commit: 52e35f0291529290363e0e2d23d5b0c1524103c1
Upstream-repository: operator-registry
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2022
@grokspawn
Copy link
Contributor Author

/hold for qe-review

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm

@Xia-Zhao-rh
Copy link

Hi, @grokspawn

zhaoxia@xzha-mac OCP-53915 % cat catalog-semver-veneer-1.yaml
Schema: olm.semver
Candidate:
  Bundles:
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v0.0.1
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1-alpha
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1-beta
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1-alpha20220829
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1-alpha20220830
Stable:
  Bundles:
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1-beta
Fast:
  Bundles:
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v0.0.1
  - Image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1-beta

 
zhaoxia@xzha-mac OCP-53915 %  opm-379 alpha render-veneer semver catalog-semver-veneer-1.yaml
2022/09/08 11:30:50 semver &{%!q(*os.file=&{{{0 0 0} 3 {0} <nil> 0 1 true true true} catalog-semver-veneer-1.yaml <nil> false false false})}: semver-render: unable to post-process bundle info: encountered bundle versions which differ only by build metadata, which cannot be ordered: [bundle version "1.0.1-alpha+20220829" cannot be compared to "1.0.1-alpha", bundle version "1.0.1-alpha+20220830" cannot be compared to "1.0.1-alpha"]

The error message is not correct, "semver &{%!q(*os.file=&{{{0 0 0} 3 {0} 0 1 true true true}" is meaningless, please don't print them.

@grokspawn
Copy link
Contributor Author

Dangit. That's related to the pipe support for semver veneer that we had. I had seen that error before, but I thought it was fixed. If you open a bug for that I can get them to investigate.

@Xia-Zhao-rh
Copy link

@grokspawn Thanks a lot. I create a bug https://issues.redhat.com/browse/OCPBUGS-1004 to track that problem.

@Xia-Zhao-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 8, 2022
@grokspawn
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@grokspawn
Copy link
Contributor Author

/test e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2022

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5955178 into openshift:master Sep 8, 2022
@openshift-ci-robot
Copy link

@grokspawn: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-650 has been moved to the MODIFIED state.

In response to this:

…s (#1009)

Signed-off-by: Jordan Keister [email protected]
Upstream-commit: 52e35f0291529290363e0e2d23d5b0c1524103c1
Upstream-repository: operator-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn grokspawn deleted the semver-candidate-fix branch September 8, 2022 18:15
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jan 15, 2025
)

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.1 to 0.19.3.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.1...v0.19.3)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: a4a9bfdc5022aba7fb42fdf01e0371caeb3e33e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants