-
Notifications
You must be signed in to change notification settings - Fork 71
OCPBUGS-1912: Move opm diff to oc mirror #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-1912: Move opm diff to oc mirror #391
Conversation
/retest-required |
1 similar comment
/retest-required |
/retest-required |
/retest-required |
1 similar comment
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we're introducing a staging/*/vendor file in one of the cherry picked commits:
$ git show HEAD~1 --stat staging/operator-registry/ | grep vendor
staging/operator-registry/vendor/modules.txt | 1313 ++++++++
Which is causing the registry unit test failures. Manually removing this nested vendor directory produces a local diff, and re-running the make unit/registry
resulted in a successful run.
/lgtm cancel
77326b3
to
536eebc
Compare
* Removed diff logic (migration to oc-mirror) * updated vendor for removed diff logic Signed-off-by: Oskar Pawica <[email protected]> Upstream-commit: d166a495355900e3d28735380f6365dfa9d10a4f Upstream-repository: operator-registry
…roperty to a channel (openshift#969) * Added the channel Priority feature * Added comments for the internal usage of Channel properties Signed-off-by: Oskar Pawica <[email protected]> Signed-off-by: Oskar Pawica <[email protected]> Co-authored-by: Oskar Pawica <[email protected]> Upstream-repository: operator-registry Upstream-commit: 208775f5a9bf02804646751ef9c7cf48d7902e9b
536eebc
to
65c171c
Compare
/retest-required |
@grokspawn: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@grokspawn: This pull request references Jira Issue OCPBUGS-1912, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@grokspawn: This pull request references Jira Issue OCPBUGS-1912, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@grokspawn: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1912 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Updated `github.com/kisielk/errcheck` from `v1.5.0` to `v1.8.0` - Updated `golang.org/x/lint` from `v0.0.0-20200302205851-738671d3881b` to `v0.0.0-20241112194109-818c5a804067` - Updated `golang.org/x/mod` from `v0.21.0` to `v0.22.0` - Updated `golang.org/x/tools` from `v0.26.0` to `v0.29.0` Added new dependencies: - `go.opentelemetry.io/otel/trace v1.28.0` - `go.opentelemetry.io/proto/otlp v1.3.1` - `golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56` Removed older dependencies: - `github.com/kisielk/errcheck v1.5.0` - `golang.org/x/lint v0.0.0-20200302205851-738671d3881b` Upstream-repository: api Upstream-commit: 61b03f0d8b727c3d4d412fbb931bb526eb665df4
No description provided.