Skip to content

provide the capability to filter mermaid output to a single package name / skipRange support (#1023) #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2022
Merged

provide the capability to filter mermaid output to a single package name / skipRange support (#1023) #400

merged 1 commit into from
Dec 14, 2022

Conversation

grokspawn
Copy link
Contributor

…

handle invalid SkipRange with output to stderr and ignoring the instance instead of dying determine package of min filter to weed out mismatches
Upstream-repository: operator-registry
Upstream-commit: 0e53cafe2df4222611796ca252b23abac3b442aa

Signed-off-by: Jordan Keister [email protected]

@openshift-ci openshift-ci bot requested review from awgreene and kevinrizza October 7, 2022 13:00
@perdasilva
Copy link
Contributor

/retest

@perdasilva
Copy link
Contributor

@grokspawn is this something that required QE? Could we update the PR title with the jira ticket?

@grokspawn
Copy link
Contributor Author

/test e2e-gcp-olm

@grokspawn
Copy link
Contributor Author

Completely lost track of this during the transition. Sorry, Per. 😦
This is an enhancement of a alpha-level function. No PX/QE/docs should be necessary.
Normally I would try to have a tracking jira, but in light of the gap this time I'm going to see about satisfying 4.next with labels.

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 16, 2022
@grokspawn
Copy link
Contributor Author

/retest

@grokspawn
Copy link
Contributor Author

/retest-required

@grokspawn
Copy link
Contributor Author

/retest

1 similar comment
@grokspawn
Copy link
Contributor Author

/retest

@grokspawn
provide the capability to filter mermaid output to a single package n…
7388cba 
…ame (openshift#1023)

handle invalid SkipRange with output to stderr and ignoring the instance instead of dying
determine package of min filter to weed out mismatches
Upstream-repository: operator-registry
Upstream-commit: 0e53cafe2df4222611796ca252b23abac3b442aa

Signed-off-by: Jordan Keister <[email protected]>
@grokspawn
Copy link
Contributor Author

/retest-required

1 similar comment
@grokspawn
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oceanc80
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2022
@oceanc80
Copy link
Contributor

/approve

1 similar comment
@awgreene
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, grokspawn, oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit f253963 into openshift:master Dec 14, 2022
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Mar 15, 2025
@dependabot
Bump sigs.k8s.io/controller-runtime from 0.20.0 to 0.20.1 (openshift#400
aedc2ed 
)

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.20.0 to 0.20.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.20.0...v0.20.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 1ed2691b9d7fba3477d1f7846a85b83ef2c3eb90
@openshift-bot openshift-bot mentioned this pull request Mar 15, 2025
Merged
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jun 11, 2025
@dependabot @grokspawn
Bump sigs.k8s.io/controller-runtime from 0.20.0 to 0.20.1 (openshift#400
5a9d4d7 
)

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.20.0 to 0.20.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.20.0...v0.20.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 1ed2691b9d7fba3477d1f7846a85b83ef2c3eb90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awgreene awgreene Awaiting requested review from awgreene

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@oceanc80 oceanc80

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grokspawn @perdasilva @oceanc80 @awgreene @openshift-merge-robot