Skip to content

OCPBUGS-1272: Add pipe support to render-veneer basic command (#1026) #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

oceanc80
Copy link
Contributor

@oceanc80 oceanc80 commented Oct 10, 2022

Signed-off-by: Catherine Chan-Tse [email protected]
Upstream-repository: operator-registry
Upstream-commit: 614d6a955dc0d7d341dfa71215b373bf401864c3

@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-1272, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Catherine Chan-Tse [email protected]
Upstream-respository: operator-registry
Upstream-commit: 614d6a955dc0d7d341dfa71215b373bf401864c3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 10, 2022
@tylerslaton
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@tylerslaton: This pull request references Jira Issue OCPBUGS-1272, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tylerslaton
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 10, 2022
@openshift-ci-robot
Copy link

@tylerslaton: This pull request references Jira Issue OCPBUGS-1272, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 10, 2022
@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh October 10, 2022 18:16
@awgreene
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@tylerslaton
Copy link
Contributor

@oceanc80 Looks like verify is failing because your commit message is slightly off.

@tylerslaton
Copy link
Contributor

This looks good to me minus the verify failure. Adding the right tags and putting a hold for when that gets fixed.

/hold
/lgtm

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022
@tylerslaton
Copy link
Contributor

/retest

@Xia-Zhao-rh
Copy link

/label qe-approved

zhaoxia@xzha-mac OCP-53869 % opm-401 version
Version: version.Version{OpmVersion:"5c21ea579", GitCommit:"5c21ea579401736368856b727c904d32838f8be6", BuildDate:"2022-10-11T01:10:05Z", GoOs:"darwin", GoArch:"amd64"}

zhaoxia@xzha-mac OCP-53869 % opm-401 alpha render-veneer         
Render a veneer type


Usage:
  opm alpha render-veneer [command]


Available Commands:
  basic       Generate a file-based catalog from a single 'basic veneer' file
When FILE is '-' or not provided, the veneer is read from standard input
  semver      Generate a file-based catalog from a single 'semver veneer' file
When FILE is '-' or not provided, the veneer is read from standard input


Flags:
  -h, --help   help for render-veneer


Global Flags:
      --skip-tls-verify   skip TLS certificate verification for container image registries while pulling bundles
      --use-http          use plain HTTP for container image registries while pulling bundles


Use "opm alpha render-veneer [command] --help" for more information about a command. 

zhaoxia@xzha-mac OCP-53869 % opm-401 alpha render-veneer basic -h
Generate a file-based catalog from a single 'basic veneer' file
When FILE is '-' or not provided, the veneer is read from standard input


Usage:
  opm alpha render-veneer basic basic-veneer-file [flags]


Flags:
  -h, --help            help for basic
  -o, --output string   Output format (json|yaml) (default "json")


Global Flags:
      --skip-tls-verify   skip TLS certificate verification for container image registries while pulling bundles
      --use-http          use plain HTTP for container image registries while pulling bundles

zhaoxia@xzha-mac OCP-53869 % cat catalog-basic-veneer.yaml 
---
schema: olm.package
name: nginx-operator
defaultChannel: stable
---
schema: olm.channel
package: nginx-operator
name: stable
entries:
- name: nginx-operator.v0.0.1
- name: nginx-operator.v1.0.1
  replaces: nginx-operator.v0.0.1
---
schema: olm.bundle
image: quay.io/olmqe/nginxolm-operator-bundle:v0.0.1
---
schema: olm.bundle
image: quay.io/olmqe/nginxolm-operator-bundle:v1.0.1

zhaoxia@xzha-mac OCP-53869 % cat catalog-basic-veneer.yaml | opm-401 alpha render-veneer basic -o yaml
---
defaultChannel: stable
name: nginx-operator
schema: olm.package
---
entries:
- name: nginx-operator.v0.0.1
- name: nginx-operator.v1.0.1
  replaces: nginx-operator.v0.0.1
name: stable
package: nginx-operator
schema: olm.channel
---
image: quay.io/olmqe/nginxolm-operator-bundle:v0.0.1
name: nginx-operator.v0.0.1
package: nginx-operator
properties:
- type: olm.gvk
  value:
    group: olm.example.com
    kind: NginxOLM
    version: v1alpha1
- type: olm.package
  value:
    packageName: nginx-operator
    version: 0.0.1
- type: olm.bundle.object
  value:
...

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 11, 2022
@tylerslaton
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-1272, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

Signed-off-by: Catherine Chan-Tse [email protected]
Upstream-repository: operator-registry
Upstream-commit: 614d6a955dc0d7d341dfa71215b373bf401864c3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80
Copy link
Contributor Author

/retest

1 similar comment
@oceanc80
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@grokspawn
Copy link
Contributor

/hold cancel now that commit comment is good and verify passing.

@grokspawn
Copy link
Contributor

/retest-required

@Xia-Zhao-rh
Copy link

/retest

@oceanc80
Copy link
Contributor Author

/test e2e-gcp-olm

@openshift-bot
Copy link
Contributor

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2022

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target OCP 4.12), recalculating validity.

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 28, 2022
@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Jira Issue OCPBUGS-1272, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target OCP 4.12), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80
Copy link
Contributor Author

oceanc80 commented Nov 1, 2022

/jira refresh

@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-1272, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Catherine Chan-Tse <[email protected]>
Upstream-repository: operator-registry
Upstream-commit: 614d6a955dc0d7d341dfa71215b373bf401864c3
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@oceanc80
Copy link
Contributor Author

oceanc80 commented Nov 1, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 1, 2022
@openshift-ci-robot
Copy link

@oceanc80: This pull request references Jira Issue OCPBUGS-1272, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor

/lgtm

@perdasilva
Copy link
Contributor

/label lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@perdasilva: The label(s) /label lgtm cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@perdasilva
Copy link
Contributor

/retest

@oceanc80
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

@oceanc80: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7d53d7d into openshift:master Nov 16, 2022
@openshift-ci-robot
Copy link

@oceanc80: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1272 has been moved to the MODIFIED state.

In response to this:

Signed-off-by: Catherine Chan-Tse [email protected]
Upstream-repository: operator-registry
Upstream-commit: 614d6a955dc0d7d341dfa71215b373bf401864c3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80 oceanc80 deleted the OCPBUGS-1272 branch November 16, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants