Skip to content

Update OWNERS file #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

Update OWNERS file #402

merged 1 commit into from
Oct 21, 2022

Conversation

awgreene
Copy link
Contributor

This commit removes a number of engineers from the OWNERS file that no longer work at Red Hat.

Signed-off-by: Alexander Greene [email protected]

@awgreene
Update OWNERS file
683a317 
This commit removes a number of engineers from the OWNERS file that no
longer work at Red Hat.

Signed-off-by: Alexander Greene <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2022
@awgreene
Copy link
Contributor Author

It would be iconic if @exdx, @njhale, or @hasbro17 approved/lgtm'd this PR.

@hasbro17
Copy link
Contributor

Since you asked :)
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
hasbro17
hasbro17 reviewed Oct 11, 2022
View reviewed changes
OWNERS
- ankitathomas
- joelanford
- timflannagan
- perdasilva
reviewers:
- njhale
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also line 2

@timflannagan
Copy link
Contributor

/retest

@timflannagan
Copy link
Contributor

This is a no-op, so adding the required no-ff labels.

/override ci/prow/e2e-gcp-olm
/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-gcp-olm

In response to this:

This is a no-op, so adding the required no-ff labels.

/override ci/prow/e2e-gcp-olm
/label px-approved
/label qe-approved
/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor

No need to recycle e2e and waste resources on a no-op.

/override ci/prow/e2e-gcp-console-olm
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-gcp-console-olm, ci/prow/e2e-gcp-ovn, ci/prow/e2e-upgrade

In response to this:

No need to recycle e2e and waste resources on a no-op.

/override ci/prow/e2e-gcp-console-olm
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ab5ecfd into openshift:master Oct 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Mar 15, 2025
@adellape
OCPBUGS#30001: Fix catalogsource typo for API docs (openshift#402)
c20c442 
* Fix catalogsource typo for API docs

* update generated files

Signed-off-by: Per Goncalves da Silva <[email protected]>

---------

Signed-off-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Upstream-repository: api
Upstream-commit: b4021ba449fae5b379958272df7cd592a6809a3f
@openshift-bot openshift-bot mentioned this pull request Mar 15, 2025
Merged
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jun 11, 2025
@adellape @grokspawn
OCPBUGS#30001: Fix catalogsource typo for API docs (openshift#402)
30e021c 
* Fix catalogsource typo for API docs

* update generated files

Signed-off-by: Per Goncalves da Silva <[email protected]>

---------

Signed-off-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Upstream-repository: api
Upstream-commit: b4021ba449fae5b379958272df7cd592a6809a3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 hasbro17 left review comments

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@hasbro17 hasbro17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awgreene @hasbro17 @timflannagan @openshift-merge-robot