Skip to content

test/e2e: Preserve the existing environment when using exec.Command #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timflannagan
Copy link
Contributor

Signed-off-by: timflannagan [email protected]

Upstream-commit: 91e5d90b3ea330c681656af7d0dc160ecb535876
Upstream-repository: operator-lifecycle-manager

…#2876)

Signed-off-by: timflannagan <[email protected]>

Upstream-commit: 91e5d90b3ea330c681656af7d0dc160ecb535876
Upstream-repository: operator-lifecycle-manager
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022
@timflannagan
Copy link
Contributor Author

This is a no-op and only affects our testing suite. Adding the required labels.

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@exdx: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor Author

lmao

@exdx
Copy link
Contributor

exdx commented Oct 21, 2022

My condolences 😄

@grokspawn
Copy link
Contributor

/lgtm

waiting on tenterhooks to see e2e-gcp-olm results ...

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@timflannagan
Copy link
Contributor Author

Looks like that worked.

/override ci/prow/e2e-gcp-olm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-gcp-olm

In response to this:

Looks like that worked.

/override ci/prow/e2e-gcp-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a3afae8 into openshift:master Oct 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@timflannagan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timflannagan timflannagan deleted the ci/fix-collect-artifacts branch October 21, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants