-
Notifications
You must be signed in to change notification settings - Fork 71
OCPBUGS-5294: backport cert rotation fix #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-5294: backport cert rotation fix #428
Conversation
@perdasilva: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@perdasilva: This pull request references Jira Issue OCPBUGS-5294, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@perdasilva: This pull request references Jira Issue OCPBUGS-5294, which is invalid:
All dependent bugs must be part of the OCPBUGS project. If you are backporting a fix that was originally tracked in Bugzilla, follow these steps to handle the backport:
Note that the mirrored bug in OCPBUGSM should not be involved in this process at all. Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@perdasilva: This pull request references Jira Issue OCPBUGS-5294, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8c36965
to
7347755
Compare
Signed-off-by: perdasilva <[email protected]>
…aming (#2715) * Add importas linting configuration to enforce common package import naming Signed-off-by: timflannagan <[email protected]> * cmd,pkg,test: Fix linting violations Signed-off-by: timflannagan <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 2194336a87354972a9bc7ea93395571f83147cf6 Signed-off-by: perdasilva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]> Signed-off-by: perdasilva <[email protected]> Co-authored-by: Per Goncalves da Silva <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: d87319abbd63a0553bd6d37f9125faba7bd40fd5
Signed-off-by: perdasilva <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: 9ced412f3e263b8827680dc0ad3477327cd9a508
7347755
to
f778e0d
Compare
/retest |
1 similar comment
/retest |
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Passed, details: https://issues.redhat.com/browse/OCPBUGS-5294 |
@jianzhangbjz: once the present PR merges, I will cherry-pick it on top of approved in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label cherry-pick-approved |
/label backport-risk-assessed |
@perdasilva: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-5294 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jianzhangbjz: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem: There was a bug in fixed in 4.11 where the operator service certificates were not being rotated properly. The current bug asks use to backport those fixed to 4.10
The backported commits are: