OCPBUGS-7086: cherry-pick pull request refactor FBC caching (#1051) f…

[grokspawn]

…rom openshift/master

refactor FBC caching (#1051)

This commit improves maintainability and extensibility of the FBC caching used to serve the GRPC API.

It:

• introduces a new cache package and interface, which defines primitives for checking cache integrity, building the cache, and loading the cache.
• moves the existing registry.Querier to an implementation of the cache interface, called cache.JSON

This refactor also resolves two outstanding issues:

1. The current code contains a bug that causes panics when certain failures occur loading the cache.
2. The current code is hardcoded to always rebuild the cache if it is unreadable or its digest doesn't contain the expected value.

This commit:

1. Refactors and removes the cases the led to the panic situation
2. Adds a new flag, --cache-enforce-integrity, that causes opm serve to exit with a failure if the cache is unreadable or its digest doesn't contain the expected value. This is useful in production contexts when one always expects the cache to be pre-populated correctly.

Signed-off-by: Joe Lanford [email protected]
Upstream-repository: operator-registry
Upstream-commit: 562cf9c9bc649f1df2bbae26f8b543529499b60f

[openshift-ci-robot]

@grokspawn: This pull request references Jira Issue OCPBUGS-7086, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.z) matches configured target version for branch (4.12.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-6741 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
• dependent Jira Issue OCPBUGS-6741 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
• bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…rom openshift/master

refactor FBC caching (#1051)

This commit improves maintainability and extensibility of the FBC caching used to serve the GRPC API.

It:

• introduces a new cache package and interface, which defines primitives for checking cache integrity, building the cache, and loading the cache.
• moves the existing registry.Querier to an implementation of the cache interface, called cache.JSON

This refactor also resolves two outstanding issues:

1. The current code contains a bug that causes panics when certain failures occur loading the cache.
2. The current code is hardcoded to always rebuild the cache if it is unreadable or its digest doesn't contain the expected value.

This commit:

1. Refactors and removes the cases the led to the panic situation
2. Adds a new flag, --cache-enforce-integrity, that causes opm serve to exit with a failure if the cache is unreadable or its digest doesn't contain the expected value. This is useful in production contexts when one always expects the cache to be pre-populated correctly.

Signed-off-by: Joe Lanford [email protected]
Upstream-repository: operator-registry
Upstream-commit: 562cf9c9bc649f1df2bbae26f8b543529499b60f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@grokspawn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

OCPBUGS-7086: cherry-pick pull request refactor FBC caching (#1051) f…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Xia-Zhao-rh]

/retest

[Xia-Zhao-rh]

LGTM, verified.
Detail: https://issues.redhat.com/browse/OCPBUGS-7086

[Xia-Zhao-rh]

/label qe-approved

[Xia-Zhao-rh]

/label cherry-pick-approved

[grokspawn]

/test e2e-upgrade

[Xia-Zhao-rh]

/retest

[grokspawn]

/retest

[grokspawn]

/retest

[Xia-Zhao-rh]

/retest

[grokspawn]

/approve

[oceanc80]

/label backport-risk-assessed

[oceanc80]

/lgtm

[oceanc80]

/approve

[gallettilance]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gallettilance, grokspawn, oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gallettilance]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2fe8e47 and 2 for PR HEAD 7db6517 in total

[grokspawn]

/retest

[grokspawn]

/retest

[openshift-ci]

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@grokspawn: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#441

Jira Issue OCPBUGS-7086 has been moved to the MODIFIED state.

In response to this:

…rom openshift/master

refactor FBC caching (#1051)

This commit improves maintainability and extensibility of the FBC caching used to serve the GRPC API.

It:

• introduces a new cache package and interface, which defines primitives for checking cache integrity, building the cache, and loading the cache.
• moves the existing registry.Querier to an implementation of the cache interface, called cache.JSON

This refactor also resolves two outstanding issues:

1. The current code contains a bug that causes panics when certain failures occur loading the cache.
2. The current code is hardcoded to always rebuild the cache if it is unreadable or its digest doesn't contain the expected value.

This commit:

1. Refactors and removes the cases the led to the panic situation
2. Adds a new flag, --cache-enforce-integrity, that causes opm serve to exit with a failure if the cache is unreadable or its digest doesn't contain the expected value. This is useful in production contexts when one always expects the cache to be pre-populated correctly.

Signed-off-by: Joe Lanford [email protected]
Upstream-repository: operator-registry
Upstream-commit: 562cf9c9bc649f1df2bbae26f8b543529499b60f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.