OCPBUGS-672: Catalog Pod Startup Probe Timeout

[dtfranz]

Updates the Startup Probe timeoutSeconds for catalog pods to be consistent with the timeouts in the readiness and liveness probes. Also adjusted the failure threshold in order to maintain the ~150s startup time failure as originally designed.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 401bfff4df20c97bef08db2dc9fc75bc1879be7a

OCPBUGS-672

[openshift-ci-robot]

@dtfranz: This pull request references Jira Issue OCPBUGS-672, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Updates the Startup Probe timeoutSeconds for catalog pods to be consistent with the timeouts in the readiness and liveness probes. Also adjusted the failure threshold in order to maintain the ~150s startup time failure as originally designed.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 401bfff4df20c97bef08db2dc9fc75bc1879be7a

OCPBUGS-672

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bandrade]

/lgtm

Timeout was added as expected

oc exec catalog-operator-7c9f79f889-xskvj -n openshift-operator-lifecycle-manager -- olm --version

OLM version: 0.19.0
git commit: f1d5d0b49182e221e7f914f53e5ed2ca07fc59da

oc get pods redhat-operators-xvl8m -o yaml -n openshift-marketplace

spec:
  containers:
  - image: registry.redhat.io/redhat/redhat-operator-index:v4.12
    imagePullPolicy: Always
    livenessProbe:
      exec:
        command:
        - grpc_health_probe
        - -addr=:50051
      failureThreshold: 3
      initialDelaySeconds: 10
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 5
    name: registry-server
    ports:
    - containerPort: 50051
      name: grpc
      protocol: TCP
    readinessProbe:
      exec:
        command:
        - grpc_health_probe
        - -addr=:50051

[dtfranz]

/lgtm

Timeout was added as expected

oc exec catalog-operator-7c9f79f889-xskvj -n openshift-operator-lifecycle-manager -- olm --version

OLM version: 0.19.0
git commit: f1d5d0b49182e221e7f914f53e5ed2ca07fc59da

oc get pods redhat-operators-xvl8m -o yaml -n openshift-marketplace

spec:
  containers:
  - image: registry.redhat.io/redhat/redhat-operator-index:v4.12
    imagePullPolicy: Always
    livenessProbe:
      exec:
        command:
        - grpc_health_probe
        - -addr=:50051
      failureThreshold: 3
      initialDelaySeconds: 10
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 5
    name: registry-server
    ports:
    - containerPort: 50051
      name: grpc
      protocol: TCP
    readinessProbe:
      exec:
        command:
        - grpc_health_probe
        - -addr=:50051

Hey @bandrade , thank you for taking a look at this! I didn't see the startupProbe in the yaml you posted, could you please also verify that the timeoutSeconds in the startupProbe is set to 5 as well?

[dtfranz]

/jira refresh

[openshift-ci-robot]

@dtfranz: This pull request references Jira Issue OCPBUGS-672, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awgreene]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dtfranz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD bae42cd and 2 for PR HEAD 8c0d84e in total

[dtfranz]

/retest

[openshift-ci]

@dtfranz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@dtfranz: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#446

Jira Issue OCPBUGS-672 has been moved to the MODIFIED state.

In response to this:

Updates the Startup Probe timeoutSeconds for catalog pods to be consistent with the timeouts in the readiness and liveness probes. Also adjusted the failure threshold in order to maintain the ~150s startup time failure as originally designed.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 401bfff4df20c97bef08db2dc9fc75bc1879be7a

OCPBUGS-672

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtfranz]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@dtfranz: new pull request created: #450

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.