-
Notifications
You must be signed in to change notification settings - Fork 71
OCPBUGS-794: remove dependence on OLM_VERSION file #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-794: remove dependence on OLM_VERSION file #462
Conversation
@ankitathomas: This pull request references Jira Issue OCPBUGS-794, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
951e9b6
to
fff66f5
Compare
fff66f5
to
963685e
Compare
@ankitathomas: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/jira refresh |
@perdasilva: This pull request references Jira Issue OCPBUGS-794, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@perdasilva: This pull request references Jira Issue OCPBUGS-794, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ankitathomas: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-794 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label qe-approved |
@ankitathomas: Jira Issue OCPBUGS-123: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-123 has been moved to the MODIFIED state. Jira Issue OCPBUGS-456 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ankitathomas: Jira Issue OCPBUGS-794 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The olm binary was using the stale upstream OLM_VERSION file for versioning. This resulted in downstream builds inaccurately displaying version.
This change switches to using the ART provided OS_GIT_VERSION or a default 0.0.0- version to version downstream olm so downstream builds can display the openshift versions they are built for.