Skip to content

OCPBUGS-794: remove dependence on OLM_VERSION file #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

ankitathomas
Copy link
Contributor

The olm binary was using the stale upstream OLM_VERSION file for versioning. This resulted in downstream builds inaccurately displaying version.

This change switches to using the ART provided OS_GIT_VERSION or a default 0.0.0- version to version downstream olm so downstream builds can display the openshift versions they are built for.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2023
@openshift-ci-robot
Copy link

@ankitathomas: This pull request references Jira Issue OCPBUGS-794, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The olm binary was using the stale upstream OLM_VERSION file for versioning. This resulted in downstream builds inaccurately displaying version.

This change switches to using the ART provided OS_GIT_VERSION or a default 0.0.0- version to version downstream olm so downstream builds can display the openshift versions they are built for.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@ankitathomas ankitathomas force-pushed the olm_version branch 3 times, most recently from 951e9b6 to fff66f5 Compare March 1, 2023 04:34
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2023

@ankitathomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@perdasilva
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-794, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 3, 2023
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-794, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 3, 2023
@openshift-ci openshift-ci bot requested a review from jianzhangbjz March 3, 2023 09:25
@openshift-merge-robot openshift-merge-robot merged commit d421904 into openshift:master Mar 3, 2023
@openshift-ci-robot
Copy link

@ankitathomas: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-794 has been moved to the MODIFIED state.

In response to this:

The olm binary was using the stale upstream OLM_VERSION file for versioning. This resulted in downstream builds inaccurately displaying version.

This change switches to using the ART provided OS_GIT_VERSION or a default 0.0.0- version to version downstream olm so downstream builds can display the openshift versions they are built for.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 13, 2023
@ankitathomas ankitathomas changed the title OCPBUGS-794: remove dependence on OLM_VERSION file OCPBUGS-123,OCPBUGS-456: remove dependence on OLM_VERSION file Mar 22, 2023
@openshift-ci-robot
Copy link

@ankitathomas: Jira Issue OCPBUGS-123: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-123 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-456 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state.

In response to this:

The olm binary was using the stale upstream OLM_VERSION file for versioning. This resulted in downstream builds inaccurately displaying version.

This change switches to using the ART provided OS_GIT_VERSION or a default 0.0.0- version to version downstream olm so downstream builds can display the openshift versions they are built for.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ankitathomas ankitathomas changed the title OCPBUGS-123,OCPBUGS-456: remove dependence on OLM_VERSION file OCPBUGS-794: remove dependence on OLM_VERSION file Mar 22, 2023
@openshift-ci-robot
Copy link

@ankitathomas: Jira Issue OCPBUGS-794 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

The olm binary was using the stale upstream OLM_VERSION file for versioning. This resulted in downstream builds inaccurately displaying version.

This change switches to using the ART provided OS_GIT_VERSION or a default 0.0.0- version to version downstream olm so downstream builds can display the openshift versions they are built for.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants