OPRUN-2913: Sync 2023 07 11

manifests/0000_50_olm_00-subscriptions.crd.yaml

@@ -645,6 +645,21 @@ spec:
                       description: 'Resources represents compute resources required by this container. Immutable. More info: https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/'
                       type: object
                       properties:
+                        claims:
+                          description: "Claims lists the names of resources, defined in spec.resourceClaims, that are used by this container. \n This is an alpha field and requires enabling the DynamicResourceAllocation feature gate. \n This field is immutable. It can only be set for containers."
+                          type: array
+                          items:
+                            description: ResourceClaim references one entry in PodSpec.ResourceClaims.
+                            type: object
+                            required:
+                              - name
+                            properties:
+                              name:
+                                description: Name must match the name of one entry in pod.spec.resourceClaims of the Pod where this field is used. It makes that resource available inside a container.
+                                type: string
+                          x-kubernetes-list-map-keys:
+                            - name
+                          x-kubernetes-list-type: map
                         limits:
                           description: 'Limits describes the maximum amount of compute resources allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
                           type: object
@@ -655,7 +670,7 @@ spec:
                               - type: string
                             x-kubernetes-int-or-string: true
                         requests:
-                          description: 'Requests describes the minimum amount of compute resources required. If Requests is omitted for a container, it defaults to Limits if that is explicitly specified, otherwise to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
+                          description: 'Requests describes the minimum amount of compute resources required. If Requests is omitted for a container, it defaults to Limits if that is explicitly specified, otherwise to an implementation-defined value. Requests cannot exceed Limits. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
                           type: object
                           additionalProperties:
                             pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
@@ -989,7 +1004,7 @@ spec:
                                 description: 'medium represents what type of storage medium should back this directory. The default is "" which means to use the node''s default medium. Must be an empty string (default) or Memory. More info: https://kubernetes.io/docs/concepts/storage/volumes#emptydir'
                                 type: string
                               sizeLimit:
-                                description: 'sizeLimit is the total amount of local storage required for this EmptyDir volume. The size limit is also applicable for memory medium. The maximum usage on memory medium EmptyDir would be the minimum value between the SizeLimit specified here and the sum of memory limits of all containers in a pod. The default is nil which means that the limit is undefined. More info: http://kubernetes.io/docs/user-guide/volumes#emptydir'
+                                description: 'sizeLimit is the total amount of local storage required for this EmptyDir volume. The size limit is also applicable for memory medium. The maximum usage on memory medium EmptyDir would be the minimum value between the SizeLimit specified here and the sum of memory limits of all containers in a pod. The default is nil which means that the limit is undefined. More info: https://kubernetes.io/docs/concepts/storage/volumes#emptydir'
                                 pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
                                 anyOf:
                                   - type: integer
@@ -1018,7 +1033,7 @@ spec:
                                         items:
                                           type: string
                                       dataSource:
-                                        description: 'dataSource field can be used to specify either: * An existing VolumeSnapshot object (snapshot.storage.k8s.io/VolumeSnapshot) * An existing PVC (PersistentVolumeClaim) If the provisioner or an external controller can support the specified data source, it will create a new volume based on the contents of the specified data source. If the AnyVolumeDataSource feature gate is enabled, this field will always have the same contents as the DataSourceRef field.'
+                                        description: 'dataSource field can be used to specify either: * An existing VolumeSnapshot object (snapshot.storage.k8s.io/VolumeSnapshot) * An existing PVC (PersistentVolumeClaim) If the provisioner or an external controller can support the specified data source, it will create a new volume based on the contents of the specified data source. When the AnyVolumeDataSource feature gate is enabled, dataSource contents will be copied to dataSourceRef, and dataSourceRef contents will be copied to dataSource when dataSourceRef.namespace is not specified. If the namespace is specified, then dataSourceRef will not be copied to dataSource.'
                                         type: object
                                         required:
                                           - kind
@@ -1034,7 +1049,7 @@ spec:
                                             description: Name is the name of resource being referenced
                                             type: string
                                       dataSourceRef:
-                                        description: 'dataSourceRef specifies the object from which to populate the volume with data, if a non-empty volume is desired. This may be any local object from a non-empty API group (non core object) or a PersistentVolumeClaim object. When this field is specified, volume binding will only succeed if the type of the specified object matches some installed volume populator or dynamic provisioner. This field will replace the functionality of the DataSource field and as such if both fields are non-empty, they must have the same value. For backwards compatibility, both fields (DataSource and DataSourceRef) will be set to the same value automatically if one of them is empty and the other is non-empty. There are two important differences between DataSource and DataSourceRef: * While DataSource only allows two specific types of objects, DataSourceRef allows any non-core object, as well as PersistentVolumeClaim objects. * While DataSource ignores disallowed values (dropping them), DataSourceRef preserves all values, and generates an error if a disallowed value is specified. (Beta) Using this field requires the AnyVolumeDataSource feature gate to be enabled.'
+                                        description: 'dataSourceRef specifies the object from which to populate the volume with data, if a non-empty volume is desired. This may be any object from a non-empty API group (non core object) or a PersistentVolumeClaim object. When this field is specified, volume binding will only succeed if the type of the specified object matches some installed volume populator or dynamic provisioner. This field will replace the functionality of the dataSource field and as such if both fields are non-empty, they must have the same value. For backwards compatibility, when namespace isn''t specified in dataSourceRef, both fields (dataSource and dataSourceRef) will be set to the same value automatically if one of them is empty and the other is non-empty. When namespace is specified in dataSourceRef, dataSource isn''t set to the same value and must be empty. There are three important differences between dataSource and dataSourceRef: * While dataSource only allows two specific types of objects, dataSourceRef allows any non-core object, as well as PersistentVolumeClaim objects. * While dataSource ignores disallowed values (dropping them), dataSourceRef preserves all values, and generates an error if a disallowed value is specified. * While dataSource only allows local objects, dataSourceRef allows objects in any namespaces. (Beta) Using this field requires the AnyVolumeDataSource feature gate to be enabled. (Alpha) Using the namespace field of dataSourceRef requires the CrossNamespaceVolumeDataSource feature gate to be enabled.'
                                         type: object
                                         required:
                                           - kind
@@ -1049,10 +1064,28 @@ spec:
                                           name:
                                             description: Name is the name of resource being referenced
                                             type: string
+                                          namespace:
+                                            description: Namespace is the namespace of resource being referenced Note that when a namespace is specified, a gateway.networking.k8s.io/ReferenceGrant object is required in the referent namespace to allow that namespace's owner to accept the reference. See the ReferenceGrant documentation for details. (Alpha) This field requires the CrossNamespaceVolumeDataSource feature gate to be enabled.
+                                            type: string
                                       resources:
                                         description: 'resources represents the minimum resources the volume should have. If RecoverVolumeExpansionFailure feature is enabled users are allowed to specify resource requirements that are lower than previous value but must still be higher than capacity recorded in the status field of the claim. More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#resources'
                                         type: object
                                         properties:
+                                          claims:
+                                            description: "Claims lists the names of resources, defined in spec.resourceClaims, that are used by this container. \n This is an alpha field and requires enabling the DynamicResourceAllocation feature gate. \n This field is immutable. It can only be set for containers."
+                                            type: array
+                                            items:
+                                              description: ResourceClaim references one entry in PodSpec.ResourceClaims.
+                                              type: object
+                                              required:
+                                                - name
+                                              properties:
+                                                name:
+                                                  description: Name must match the name of one entry in pod.spec.resourceClaims of the Pod where this field is used. It makes that resource available inside a container.
+                                                  type: string
+                                            x-kubernetes-list-map-keys:
+                                              - name
+                                            x-kubernetes-list-type: map
                                           limits:
                                             description: 'Limits describes the maximum amount of compute resources allowed. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
                                             type: object
@@ -1063,7 +1096,7 @@ spec:
                                                 - type: string
                                               x-kubernetes-int-or-string: true
                                           requests:
-                                            description: 'Requests describes the minimum amount of compute resources required. If Requests is omitted for a container, it defaults to Limits if that is explicitly specified, otherwise to an implementation-defined value. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
+                                            description: 'Requests describes the minimum amount of compute resources required. If Requests is omitted for a container, it defaults to Limits if that is explicitly specified, otherwise to an implementation-defined value. Requests cannot exceed Limits. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/'
                                             type: object
                                             additionalProperties:
                                               pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$

manifests/0000_90_olm_00-service-monitor.yaml

@@ -78,7 +78,6 @@ metadata:
     include.release.openshift.io/ibm-cloud-managed: "true"
     include.release.openshift.io/self-managed-high-availability: "true"
 spec:
-  jobLabel: k8s-app
   endpoints:
     - bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
       interval: 30s

pkg/manifests/csv.yaml

@@ -5,7 +5,7 @@ metadata:
   name: packageserver
   namespace: openshift-operator-lifecycle-manager
   labels:
-    olm.version: 0.19.0
+    olm.version: 0.0.0-e17b6a389771f79426879e9feeae14d959b90e48
     olm.clusteroperator.name: operator-lifecycle-manager-packageserver
   annotations:
     include.release.openshift.io/self-managed-high-availability: "true"
@@ -159,7 +159,7 @@ spec:
                                 - packageserver
                         topologyKey: "kubernetes.io/hostname"
   maturity: alpha
-  version: 0.19.0
+  version: 0.0.0-e17b6a389771f79426879e9feeae14d959b90e48
   apiservicedefinitions:
     owned:
       - group: packages.operators.coreos.com

scripts/sync.sh

@@ -38,13 +38,15 @@ candidates() {
     for remote in "${UPSTREAM_REMOTES[@]}"; do
         "${ROOT_DIR}"/scripts/sync_get_candidates.sh "$remote"
     done
+
+    # Create uber cherry-pick list
+    cat *.cherrypick | sort > all.cherrypick
+    echo "Number of commits to cherrypick: $(cat all.cherrypick | wc -l)"
 }
 
 pop() {
     echo "Applying all upstream commit candidates"
-    for remote in "${UPSTREAM_REMOTES[@]}"; do
-        "${ROOT_DIR}"/scripts/sync_pop_candidate.sh -a "${remote}"
-    done
+    "${ROOT_DIR}"/scripts/sync_pop_candidate.sh -a "all"
 }
 
 check_local_branch_commit_diff() {

scripts/sync_get_candidates.sh

@@ -28,7 +28,7 @@ cherrypick_set="${remote}.cherrypick"
 : > "${cherrypick_set}" # clear existing file
 for rc in "${remote_commits[@]}"; do
     if [[ -z $(git log -n 1 --no-merges --grep "${rc}" HEAD) && -z $(grep "${rc}" "${remote}.blacklist") ]]; then
-        printf '%s\n' "${rc}" >> "${cherrypick_set}"
+        git show -s --format="%cI ${remote} %H" "${rc}" >> "${cherrypick_set}"
         (( ++picked ))
     fi
 done

scripts/sync_pop_candidate.sh

@@ -2,6 +2,7 @@
 
 set -o errexit
 set -o pipefail
+#set -x
 
 ROOT_DIR=$(dirname "${BASH_SOURCE[@]}")/..
 # shellcheck disable=SC1091
@@ -30,33 +31,50 @@ function pop() {
         printf 'nothing to pick'
         exit
     fi
+    readarray -t rcs < <(echo "$rc" | tr " " "\n")
+    remote="${rcs[1]}"
+    subtree_dir="staging/${remote}"
+    rc="${rcs[2]}"
     printf 'popping: %s\n' "${rc}"
 
     if ! git cherry-pick --allow-empty --keep-redundant-commits -Xsubtree="${subtree_dir}" "${rc}"; then
         # Always blast away the vendor directory given OLM/registry still commit it into source control.
         git rm -rf "${subtree_dir}"/vendor 2>/dev/null || true
 
+        # Look for any deleted by us
+        readarray -t deletes < <(git status --porcelain| grep -oP "^DU \K.*")
+        for d in "${deletes[@]}"; do
+            git rm "${d}"
+        done
+        echo "Done with deletes"
+
+        # Handle other conflicts
         num_conflicts=$(git diff --name-only --diff-filter=U --relative | wc -l)
         while [[ $num_conflicts != 0 ]] ; do
-            file=$(git diff --name-only --diff-filter=U --relative)
-
-            if [[ $file == *"go.mod"* ]]; then
-                git diff "${subtree_dir}"/go.mod
-
-                git checkout --theirs "${subtree_dir}"/go.mod
-                pushd "${subtree_dir}"
-                go mod tidy
-                git add go.mod go.sum
-                popd
-            else
-                git checkout --theirs "$file"
-                git diff "$file"
-                git add "$file"
-            fi
+            readarray -t files < <(git diff --name-only --diff-filter=U --relative)
+
+            for f in "${files[@]}"; do
+
+                # Note that this can be a problem if there are regressions! (e.g. 1.2 -> 1.1)
+                if [[ ${f} == *"go.mod"* ]]; then
+                    git diff "${subtree_dir}"/go.mod
+
+                    git checkout --theirs "${subtree_dir}"/go.mod
+                    pushd "${subtree_dir}"
+                    go mod tidy
+                    git add go.mod go.sum
+                    popd
+                else
+                    git checkout --theirs "${f}"
+                    git diff "${f}"
+                    git add "${f}"
+                fi
+            done
 
             num_conflicts=$(git diff --name-only --diff-filter=U --relative | wc -l)
             echo "Number of merge conflicts remaining: $num_conflicts"
         done
+        echo "Done with conflicts"
 
         if [[ -z $(git status --porcelain) ]]; then
             git commit --allow-empty
@@ -66,16 +84,36 @@ function pop() {
         fi
     fi
 
+    # Did go.mod change?
+    if ! git diff --quiet HEAD^ "${subtree_dir}"/go.mod; then
+        git diff HEAD^ "${subtree_dir}"/go.mod
+        pushd "${subtree_dir}"
+        echo "Running BASH subshell: go.mod has changed, check for regressions!"
+        echo -n '<ENTER> to continue, ^C to quit: '
+        read
+        popd
+    fi
 
     # 1. Pop next commit off cherrypick set
     # 2. Cherry-pick
     # 3. Ammend commit
     # 4. Remove from cherrypick set
-    make vendor
-    make manifests
+    if ! make vendor; then
+        echo "Running BASH subshell: fix make vendor"
+        echo -n '<ENTER> to continue, ^C to quit: '
+        read
+    fi
     git add "${subtree_dir}" "${ROOT_GENERATED_PATHS[@]}"
     git status
     git commit --amend --allow-empty --no-edit --trailer "Upstream-repository: ${remote}" --trailer "Upstream-commit: ${rc}"
+    if ! make manifests; then
+        echo "Running BASH subshell: fix make manifests"
+        echo -n '<ENTER> to continue, ^C to quit: '
+        read
+    fi
+    git add "${subtree_dir}" "${ROOT_GENERATED_PATHS[@]}"
+    git status
+    git commit --amend --allow-empty --no-edit
 
     tmp_set=$(mktemp)
     tail -n +2 "${cherrypick_set}" > "${tmp_set}"; cat "${tmp_set}" > "${cherrypick_set}"

staging/api/.github/workflows/go.yaml

@@ -13,9 +13,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Set up Go
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
-        go-version: 1.18
+        go-version: 1.19
       id: go
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
@@ -29,17 +29,22 @@ jobs:
         restore-keys: |
           ${{ runner.os }}-go-
     - name: unit-test
-      run: go test -v ./...
+      run: go test -v ./... -coverprofile cover.out
+    - uses: codecov/codecov-action@v3
+      with:
+        files: cover.out
+        fail_ci_if_error: true
+        functionalities: fixes
 
   go-apidiff:
     name: go-apidiff
     if: github.event_name == 'pull_request'
     runs-on: ubuntu-latest
     steps:
     - name: Set up Go
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v3
       with:
-        go-version: 1.18
+        go-version: 1.19
       id: go
     - name: Print out Go env
       run: go env