Skip to content

OCPBUGS-17950: Make packageserver wakeup interval configurable #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 25, 2023

The packageserver wakeup interval is used to update its package manifest from CatSrcs. However, this does not need to happen periodically (especially 5m) as the CatSrc pods will restart when a change occurs to data it is caching, and this will be acted upon by packageserver.

This allows configuration of this interval via the package-server-manager deployment (which then gets passed onto the packageserver deployment).

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 25, 2023
@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-17950, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The packageserver wakeup interval is used to update its package manifest from CatSrcs. However, this does not need to happen periodically (especially 5m) as the CatSrc pods will restart when a change occurs to data it is caching, and this will be acted upon by packageserver.

This allows configuration of this interval via the package-server-manager deployment (which then gets passed onto the packageserver deployment).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz August 25, 2023 20:03
@tmshort
Copy link
Contributor Author

tmshort commented Aug 25, 2023

Alternative to #553

@openshift-ci openshift-ci bot requested review from awgreene and perdasilva August 25, 2023 20:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@tmshort
Copy link
Contributor Author

tmshort commented Aug 25, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2023
@tmshort tmshort force-pushed the OCPBUGS-17950a branch 3 times, most recently from f3c96db to fa69fd6 Compare August 28, 2023 17:36
@tmshort
Copy link
Contributor Author

tmshort commented Aug 28, 2023

/retest

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@tmshort tmshort changed the title OCPBUGS-17950: Make packaeserver wakeup interval configurable OCPBUGS-17950: Make packageserver wakeup interval configurable Aug 29, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
The packageserver wakeup interval is used to update its package
manifest from CatSrcs. However, this does not need to happen
periodically (especially 5m) as the CatSrc pods will restart
when a change occurs to data it is caching, and this will be
acted upon by packageserver.

This allows configuration of this interval via the
package-server-manager deployment (which then gets passed
onto the packageserver deployment).

Signed-off-by: Todd Short <[email protected]>
@tmshort
Copy link
Contributor Author

tmshort commented Aug 29, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@tmshort
Copy link
Contributor Author

tmshort commented Aug 30, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@tmshort: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@jianzhangbjz
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 6, 2023
@jianzhangbjz
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6799db7 into openshift:master Sep 6, 2023
@openshift-ci-robot
Copy link

@tmshort: Jira Issue OCPBUGS-17950: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17950 has been moved to the MODIFIED state.

In response to this:

The packageserver wakeup interval is used to update its package manifest from CatSrcs. However, this does not need to happen periodically (especially 5m) as the CatSrc pods will restart when a change occurs to data it is caching, and this will be acted upon by packageserver.

This allows configuration of this interval via the package-server-manager deployment (which then gets passed onto the packageserver deployment).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmshort tmshort deleted the OCPBUGS-17950a branch October 23, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants