OCPBUGS-3516: fix CSV unmarshaling error with custom unmarshaler with pretty errors (#1138) #557
Conversation
… (#1138) Signed-off-by: Jordan Keister <[email protected]>
openshift-ci-robot
added
jira/valid-reference
|
@grokspawn: This pull request references Jira Issue OCPBUGS-3516, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/retest |
|
/retest |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
| @@ -6,6 +6,8 @@ import ( | |||
| "errors" | |||
| "fmt" | |||
|
|
|||
| prettyunmarshaler "github.com/operator-framework/operator-registry/pkg/prettyunmarshaler" | |||
There was a problem hiding this comment.
nit: these import aliases are not needed
|
Looks like it is a cherrypick. Let's get it in, in order, so future upstream syncs to master branch are not out-of-order. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test |
|
@grokspawn: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@grokspawn It is likely not worth your time to re-test this, as it should be pulled in via a sync, not on it's own. |
|
/retest |
|
@grokspawn: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Now part of #562 |
|
Duplicate of #562 |
|
@grokspawn: This pull request references Jira Issue OCPBUGS-3516. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Also including a change to root .gitignore for test dockerfiles created during repo verification steps.