Skip to content

Sync 2023 10 05 no steve #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 10, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 10, 2023

No description provided.

tmshort and others added 12 commits October 9, 2023 16:50
Signed-off-by: Todd Short <[email protected]>
Upstream-repository: api
Upstream-commit: 7961b0208d99b3e059a0607663dba547a7e685d7
Signed-off-by: Todd Short <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a627c78f19b624a1e45340902beea1bd1117eff2
The API was updated to include `packageServerSyncInterval`

In the packageserver, read the OLMConfig at init and set the
sourceProvider timeout from that (or default).

Watch the OLMConfig resource and if the sync interval changes,
restart the sourceProvider.

Signed-off-by: Todd Short <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 25ed6839c188dd387cbe4105798d1bd1933814b7
Signed-off-by: Todd Short <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 2d66602401c42be5a0806b71f965ac217d66794e
Remove unused function.
Remove possibly verbose log statement.

Signed-off-by: Todd Short <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: fa51d6f651791a0f6eb3e288140f5e495d4138ff
Signed-off-by: Ankita Thomas <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: a06d7d70f30f577ac167b1c5584b931d5447025b
… unpack jobs

Signed-off-by: Ankita Thomas <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 07d8b910f42b90869b6fa7686cf2a8ad09956540
Signed-off-by: Ankita Thomas <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 218a6bb495152b89bd84286b051190b3e58e2b00
Signed-off-by: Ankita Thomas <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 4fc64d230962fa9cd69a1dc2bc3e4244af452e13
Signed-off-by: Daniele Trifirò <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 0da1ae215f2e9cb0de0b3a51286818d8911f6018
This commit updates all of OLM e2e test suites to generate a namespace
rather than using a hard coded test namespace passed into the test as a
parameter. The motivation for this change include:
1. Decreasing the opportunity for tests to influence each other. Tests
   are not guaranteed to cleanup after themselves and may influence the
   results of other tests.
2. Some distributions of OLM run alongside other controllers which may
   revert changes to resources in predetermined namespaces.

Signed-off-by: Alexander Greene <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 108d6db0d11d5224214904c02e91391b0aada286
The sync default sync interval was changed to 12 hours, but there is
also a CLI option that also configures the sync interval.

The OLMConfig reconcile code did not properly handle the value coming
in via the CLI, and changing the sync interval from the default
without an OLMConfig value specified.

The CLI option now changes the default sync interval, when the
OLMConfig is not present. The 12h default sync interval is used when
neither the CLI nor the OLMConfig is specified. The OLMConfig
reconcile code now uses the CLI option as the default.

Signed-off-by: Todd Short <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 5a680ad110c8aaf76b3aad975632d75cb5fa3e25
@openshift-ci openshift-ci bot requested review from anik120 and awgreene October 10, 2023 14:44
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@tmshort
Copy link
Contributor Author

tmshort commented Oct 10, 2023

/retest

2 similar comments
@tmshort
Copy link
Contributor Author

tmshort commented Oct 10, 2023

/retest

@tmshort
Copy link
Contributor Author

tmshort commented Oct 10, 2023

/retest

@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 586ee40 into openshift:master Oct 10, 2023
@tmshort tmshort deleted the sync-2023-10-05-no-steve branch October 11, 2023 12:33
@jianzhangbjz
Copy link
Contributor

Test pass, details: https://issues.redhat.com/browse/OCPBUGS-17950
image

image

/label qe-approved
/lgtm

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants