scripts/bumper: improve sort order #580
Conversation
While we want to use date to order commits between repositories, where there is no real order, we must not change the order of commits within a repo. Signed-off-by: Steve Kuznetsov <[email protected]>
|
/retest |
|
/test all |
|
A few minor comments. But it seems you are trying to pull in the same improvement I did in #578 ? |
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/better-sort
branch
from
ccb764f to
0158c8c
Compare
|
@tmshort yes, as you can see in my original bump PR I ran into it then :) |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/override e2e-gcp-olm |
|
@joelanford: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stevekuznetsov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Manually merging as e2e failures are unrelated to this PR |
While we want to use date to order commits between repositories, where there is no real order, we must not change the order of commits within a repo.