Skip to content

OCPBUGS-18948: CRD Compatibility Validation #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Oct 17, 2023

Correct CRD validation to validate CRs against each version of the updated CRD.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 242f63f

…dated CRD

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 242f63f

Signed-off-by: Daniel Franz <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 17, 2023
@openshift-ci-robot
Copy link

@dtfranz: This pull request references Jira Issue OCPBUGS-18948, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Correct CRD validation to validate CRs against each version of the updated CRD.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 242f63f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtfranz
Copy link
Contributor Author

dtfranz commented Oct 17, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 17, 2023
@openshift-ci-robot
Copy link

@dtfranz: This pull request references Jira Issue OCPBUGS-18948, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 17, 2023
@openshift-ci openshift-ci bot requested review from awgreene and grokspawn October 17, 2023 04:07
@eggfoobar
Copy link
Contributor

/retest-required

@tmshort
Copy link
Contributor

tmshort commented Oct 17, 2023

This should wait for the automated sync... and everything else that's happening to fix testing.

@dtfranz
Copy link
Contributor Author

dtfranz commented Oct 17, 2023

This should wait for the automated sync... and everything else that's happening to fix testing.

Gotcha, I figured since the periodic job was failing then doing it manually would be the right move, but if you don't think so I can close this.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

@dtfranz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm-flaky 4f9113e link false /test e2e-gcp-olm-flaky

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tmshort
Copy link
Contributor

tmshort commented Oct 20, 2023

/retest

@tmshort
Copy link
Contributor

tmshort commented Oct 20, 2023

/test e2e-gcp-olm

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit cebc5d5 into openshift:master Oct 21, 2023
@openshift-ci-robot
Copy link

@dtfranz: Jira Issue OCPBUGS-18948: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18948 has been moved to the MODIFIED state.

In response to this:

Correct CRD validation to validate CRs against each version of the updated CRD.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 242f63f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants