Skip to content

OPRUN-3063: Generate OLM microshift manifests #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

jmprusi
Copy link
Contributor

@jmprusi jmprusi commented Nov 8, 2023

This PR adds the necessary changes to 'scripts/generate_crds_manifests.sh' to create a new set of manifests specifically targeted for microshift.

@openshift-ci openshift-ci bot requested review from ncdc and tmshort November 8, 2023 14:36
@ncdc
Copy link
Contributor

ncdc commented Nov 8, 2023

@jmprusi please split this into 2 commits - 1 for the script edits, 1 for the generated files. Thanks!

@jmprusi jmprusi force-pushed the jmprusi/microshift-olm branch from b5b7b5b to 30b512f Compare November 8, 2023 14:44
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 8, 2023

@ncdc done, PTAL.

@ncdc
Copy link
Contributor

ncdc commented Nov 8, 2023

Need to fix verify failure

@jmprusi jmprusi force-pushed the jmprusi/microshift-olm branch from 30b512f to 4ed63c2 Compare November 8, 2023 14:49
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 8, 2023

Need to fix verify failure

make verify returns 0 locally. looks like we are having some CI issues? checking.

@ncdc
Copy link
Contributor

ncdc commented Nov 8, 2023

It's complaining about kustomization.yaml

@jmprusi jmprusi force-pushed the jmprusi/microshift-olm branch 2 times, most recently from e876311 to 59eb9a6 Compare November 8, 2023 20:05
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 8, 2023

It's complaining about kustomization.yaml

Fixed... It looks like find ordering is different in Macos vs Linux.

@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 9, 2023

/retest-required

1 similar comment
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 10, 2023

/retest-required

@jmprusi jmprusi requested a review from ncdc November 10, 2023 13:14
@jmprusi jmprusi force-pushed the jmprusi/microshift-olm branch 4 times, most recently from 4bca4a7 to 24307d4 Compare November 13, 2023 14:52
This commit includes changes to the generate_crds_manifests.sh script to
generate a new set of manifests with the required changes to work on
microshift.

Signed-off-by: Joaquim Moreno Prusi <[email protected]>
Signed-off-by: Joaquim Moreno Prusi <[email protected]>
@jmprusi jmprusi force-pushed the jmprusi/microshift-olm branch from 24307d4 to 0e8e3ab Compare November 13, 2023 14:53
Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

@jmprusi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmprusi jmprusi requested a review from ncdc November 14, 2023 10:07
@ncdc
Copy link
Contributor

ncdc commented Nov 14, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
Copy link
Contributor

openshift-ci bot commented Nov 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmprusi, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@ncdc ncdc added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 14, 2023
@jmprusi jmprusi changed the title Generate OLM microshift manifests OPRUN-3063: Generate OLM microshift manifests Nov 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 14, 2023

@jmprusi: This pull request references OPRUN-3063 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

This PR adds the necessary changes to 'scripts/generate_crds_manifests.sh' to create a new set of manifests specifically targeted for microshift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b7b223c into openshift:master Nov 14, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.15.0-202311142350.p0.gb7b223c.assembly.stream for distgit operator-lifecycle-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants