-
Notifications
You must be signed in to change notification settings - Fork 71
OPRUN-3063: Generate OLM microshift manifests #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPRUN-3063: Generate OLM microshift manifests #604
Conversation
@jmprusi please split this into 2 commits - 1 for the script edits, 1 for the generated files. Thanks! |
b5b7b5b
to
30b512f
Compare
@ncdc done, PTAL. |
Need to fix verify failure |
30b512f
to
4ed63c2
Compare
|
It's complaining about kustomization.yaml |
e876311
to
59eb9a6
Compare
Fixed... It looks like |
/retest-required |
1 similar comment
/retest-required |
4bca4a7
to
24307d4
Compare
This commit includes changes to the generate_crds_manifests.sh script to generate a new set of manifests with the required changes to work on microshift. Signed-off-by: Joaquim Moreno Prusi <[email protected]>
Signed-off-by: Joaquim Moreno Prusi <[email protected]>
24307d4
to
0e8e3ab
Compare
@jmprusi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmprusi, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jmprusi: This pull request references OPRUN-3063 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build operator-lifecycle-manager-container-v4.15.0-202311142350.p0.gb7b223c.assembly.stream for distgit operator-lifecycle-manager. |
This PR adds the necessary changes to 'scripts/generate_crds_manifests.sh' to create a new set of manifests specifically targeted for microshift.