Skip to content

OPECO-3066: Synchronize From Upstream Repositories #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Nov 17, 2023

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2023-11-17 14:41:26 operator-framework/operator-lifecycle-manager@db965b0 Alexander Greene Bump o-f/operator-registry and o-f/api dependencies
2023-11-17 14:41:26 operator-framework/operator-lifecycle-manager@e7debb4 Alexander Greene Surface deprecation information in PackageManifests
2023-11-17 14:41:26 operator-framework/operator-lifecycle-manager@4655321 Alexander Greene PackageManifest Deprecation Unit Tests
2023-11-17 15:01:49 operator-framework/operator-lifecycle-manager@658a6a6 Steve Kuznetsov *: use a stable hash for client-side short-circuits
2023-11-17 14:03:39 operator-framework/api@5efe1a2 Eng Zer Jun Replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#308)
2023-11-16 17:33:20 operator-framework/operator-registry@39df3b7 Jordan Keister Deprecation utests (#1164)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

@openshift-bot openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Nov 17, 2023
@openshift-ci openshift-ci bot requested a review from a team November 17, 2023 00:02
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

@openshift-bot: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-operator-ecosystem.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2023-11-16 17:33:20 operator-framework/operator-registry@39df3b7 Jordan Keister Deprecation utests (#1164)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor

tmshort commented Nov 17, 2023

It appears that cluster installation failed, not a flake.

/retest

awgreene and others added 6 commits November 17, 2023 15:25
Signed-off-by: Alexander Greene <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: db965b08107161d0da95f52db6365d9fc78c6118
Signed-off-by: Alexander Greene <[email protected]>
Co-authored-by: Kevin Rizza <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e7debb4631cc1607180a57f73da686a075a38a50
Signed-off-by: Alexander Greene <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 4655321370258ac76e194b027d845a8154a74ae2
The previous approach here was to use go-spew, which, unfortunately, is
not a stable and germane encoding for objects. We are encoding objects
that we send to the Kubernetes API server, so features of go-spew like
printing the capacity of slices are not germane. This led to hashes of
otherwise identical (as far as the server was concerned) objects to be
determined as hashing differently.

Signed-off-by: Steve Kuznetsov <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 658a6a60de8315f055f54aa7e50771ee4daa8983
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <[email protected]>
Upstream-repository: api
Upstream-commit: 5efe1a23d8c21e51c6a63a472a0d5320342187ec
* deprecations unit tests

Signed-off-by: Jordan Keister <[email protected]>

* review updates

Signed-off-by: Jordan Keister <[email protected]>

* dogmatic review updates

Signed-off-by: Jordan Keister <[email protected]>

---------

Signed-off-by: Jordan Keister <[email protected]>
Upstream-repository: operator-registry
Upstream-commit: 39df3b78e77574c64cc05e480cbd6fe83cf2b428
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2023
@ncdc ncdc added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 17, 2023
@grokspawn
Copy link
Contributor

grokspawn commented Nov 17, 2023

/retitle OPECO-3066: Synchronize From Upstream Repositories

@openshift-ci openshift-ci bot changed the title Synchronize From Upstream Repositories OPECO-3066: Synchronize From Upstream Repositories Nov 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023

@openshift-bot: This pull request references OPECO-3066 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2023-11-17 14:41:26 operator-framework/operator-lifecycle-manager@db965b0 Alexander Greene Bump o-f/operator-registry and o-f/api dependencies
2023-11-17 14:41:26 operator-framework/operator-lifecycle-manager@e7debb4 Alexander Greene Surface deprecation information in PackageManifests
2023-11-17 14:41:26 operator-framework/operator-lifecycle-manager@4655321 Alexander Greene PackageManifest Deprecation Unit Tests
2023-11-17 15:01:49 operator-framework/operator-lifecycle-manager@658a6a6 Steve Kuznetsov *: use a stable hash for client-side short-circuits
2023-11-17 14:03:39 operator-framework/api@5efe1a2 Eng Zer Jun Replace github.com/ghodss/yaml with sigs.k8s.io/yaml (#308)
2023-11-16 17:33:20 operator-framework/operator-registry@39df3b7 Jordan Keister Deprecation utests (#1164)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/cc @openshift/openshift-team-operator-runtime
/cc @openshift/openshift-team-operator-ecosystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 464202c and 2 for PR HEAD d663a0d in total

@tmshort
Copy link
Contributor

tmshort commented Nov 17, 2023

Two failures:

  [FAIL] Subscription when bundle unpack retries are enabled [It] should not retry successful unpack jobs
  /go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/subscription_e2e_test.go:2732
  [FAIL] Install Plan [It] creation with permissions
  /go/src/github.com/openshift/operator-framework-olm/staging/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:2905

We've seen one of these before.
operator-framework/operator-lifecycle-manager#3062 which this PR ought to have a fix for creation with permissions

Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 639fc12 into openshift:master Nov 17, 2023
@openshift-bot
Copy link
Contributor Author

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-registry-container-v4.15.0-202311172250.p0.g639fc12.assembly.stream for distgit operator-registry.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants