Skip to content

OPRUN-3063: Microshift manifests remove collection-profiles cronjob from kustomization #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2023
Merged

OPRUN-3063: Microshift manifests remove collection-profiles cronjob from kustomization #615

merged 2 commits into from
Nov 27, 2023

Conversation

jmprusi
Copy link
Contributor

@jmprusi jmprusi commented Nov 22, 2023

Removes the collect profiles cronjob from the microshift kustomization.yaml file.

@openshift-ci openshift-ci bot requested review from joelanford and ncdc November 22, 2023 16:14
@jmprusi jmprusi changed the title Microshift manifests: remove collection-profiles cronjob from kustomization OPRUN-3063: Microshift manifests remove collection-profiles cronjob from kustomization Nov 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2023 •
edited by openshift-ci bot
Loading

@jmprusi: This pull request references OPRUN-3063 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Removes the collect profiles cronjob from the microshift kustomization.yaml file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2023 •
edited by openshift-ci bot
Loading

@grokspawn: This pull request references OPRUN-3063 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Contributor

Could you retitle your commit messages to include the UPSTREAM: <carry>: prefix so we know to keep them when we downstream add'l feature content?

awgreene
awgreene approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2023
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 22, 2023

/retest-required

1 similar comment
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 23, 2023

/retest-required

@jmprusi jmprusi force-pushed the jmprusi/microshift-remove-cronjob branch from e3fcd84 to 9af0bcf Compare November 23, 2023 11:09
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 24, 2023

/retest-required

m1kola
m1kola approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 27, 2023

/retest-required

@jmprusi
Copy link
Contributor Author

jmprusi commented Nov 27, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 639fc12 and 2 for PR HEAD 9af0bcf in total

@jmprusi jmprusi force-pushed the jmprusi/microshift-remove-cronjob branch from 9af0bcf to c933792 Compare November 27, 2023 15:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@awgreene
Copy link
Contributor

/lgtm

m1kola
m1kola approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@m1kola m1kola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, jmprusi, m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

@jmprusi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm-flaky c933792 link false /test e2e-gcp-olm-flaky

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2223459 into openshift:master Nov 27, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build operator-lifecycle-manager-container-v4.15.0-202311272131.p0.g2223459.assembly.stream for distgit operator-lifecycle-manager.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1kola m1kola m1kola approved these changes

@awgreene awgreene awgreene approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@m1kola m1kola

@awgreene awgreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmprusi @openshift-ci-robot @grokspawn @awgreene @openshift-bot @m1kola