-
Notifications
You must be signed in to change notification settings - Fork 71
[release-4.15] OCPBUGS-25367: [CARRY] Fix panic issue when annotations map is nil #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In some cases, secrets do not have any annotations and the annotations map are nil. The annotations map needs to be initialized to avoid panic error. Signed-off-by: Vu Dinh <[email protected]>
@openshift-cherrypick-robot: Jira Issue OCPBUGS-25339 has been cloned as Jira Issue OCPBUGS-25367. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25367, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test pass, details: https://issues.redhat.com/browse/OCPBUGS-25367 |
/jira refresh |
@jianzhangbjz: This pull request references Jira Issue OCPBUGS-25367, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@jianzhangbjz: This pull request references Jira Issue OCPBUGS-25367, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@dinhxuanvu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25367. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jianzhangbjz Would you mind retagging the new PR #635? I think I messed up the cherry-pick command on the this PR and it missed the CARRY tag. My apology. Thanks. |
I guess you mean #636, sure, done. |
This is an automated cherry-pick of #634
/assign dinhxuanvu